refs #2373 - Change error type string and do not pass the default empty array

Morerice · Morerice · commit 6a09f8c7b0a8 · 2019-12-10T10:05:11.000+01:00
diff --git a/src/Standards/Generic/Sniffs/PHP/DisallowRequestSuperGlobalSniff.php b/src/Standards/Generic/Sniffs/PHP/DisallowRequestSuperGlobalSniff.php
@@ -45,9 +45,8 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        $type  = 'RequestSuperGlobalAccessed';
         $error = 'The $_REQUEST super global should not be used. Use $_GET, $_POST or $_COOKIE instead';
-        $phpcsFile->addError($error, $stackPtr, $type, []);
+        $phpcsFile->addError($error, $stackPtr, 'Found');
 
     }//end process()
 

Original file line number	Diff line number	Diff line change
`@@ -45,9 +45,8 @@ public function process(File $phpcsFile, $stackPtr)`
`45`	`45`	`return;`
`46`	`46`	`}`
`47`	`47`
`48`		`- $type = 'RequestSuperGlobalAccessed';`
`49`	`48`	`$error = 'The $_REQUEST super global should not be used. Use $_GET, $_POST or $_COOKIE instead';`
`50`		`- $phpcsFile->addError($error, $stackPtr, $type, []);`
	`49`	`+ $phpcsFile->addError($error, $stackPtr, 'Found');`
`51`	`50`
`52`	`51`	`}//end process()`
`53`	`52`