Skip to content

Commit 76fce40

Browse files
committed
File::isReference(): simplify code
The `File::getMethodParameters()` returns a `reference_token` index, so no need to do any token walking.
1 parent 1371c59 commit 76fce40

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

src/Files/File.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1981,19 +1981,7 @@ public function isReference($stackPtr)
19811981
) {
19821982
$params = $this->getMethodParameters($this->tokens[$lastBracket]['parenthesis_owner']);
19831983
foreach ($params as $param) {
1984-
$varToken = $tokenAfter;
1985-
if ($param['variable_length'] === true) {
1986-
$varToken = $this->findNext(
1987-
(Util\Tokens::$emptyTokens + [T_ELLIPSIS]),
1988-
($stackPtr + 1),
1989-
null,
1990-
true
1991-
);
1992-
}
1993-
1994-
if ($param['token'] === $varToken
1995-
&& $param['pass_by_reference'] === true
1996-
) {
1984+
if ($param['reference_token'] === $stackPtr) {
19971985
// Function parameter declared to be passed by reference.
19981986
return true;
19991987
}

0 commit comments

Comments
 (0)