Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

transport: ssh, keeping the original path #189

Merged
merged 1 commit into from
Dec 15, 2016
Merged

transport: ssh, keeping the original path #189

merged 1 commit into from
Dec 15, 2016

Conversation

mcuadros
Copy link
Contributor

For some reason, we where removing the initial "/" in the path, this is wrong:

  • At GitHub, /foo and foo are exactly the same thing
  • In a bare git server, /foo and foo not are the same thing, ending in a "Not Found repository"

I don't know how provide a test because, this was not tested, so since I am removing "feature" don't require a test, at least as I see

@codecov-io
Copy link

codecov-io commented Dec 14, 2016

Current coverage is 77.41% (diff: 0.00%)

Merging #189 into master will decrease coverage by 0.67%

@@             master       #189   diff @@
==========================================
  Files            92         92          
  Lines          5882       5880     -2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           4593       4552    -41   
- Misses          804        851    +47   
+ Partials        485        477     -8   

Powered by Codecov. Last update 825c00d...1acd93b

@mcuadros mcuadros merged commit 72b1577 into src-d:master Dec 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants