update transport Command interface to support SetAuth after creation #210
Conversation
Current coverage is 76.28% (diff: 61.90%)@@ master #210 diff @@
==========================================
Files 96 96
Lines 6278 6299 +21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4824 4805 -19
- Misses 925 971 +46
+ Partials 529 523 -6
|
| @@ -46,6 +46,8 @@ type Commander interface { | |||
| type Command interface { | |||
| // SetAuth sets the authentication method. | |||
| SetAuth(transport.AuthMethod) error | |||
| // Perform the actual network connection. | |||
| Connect() error | |||
There was a problem hiding this comment.
SetAuth is actually a leftover from a previous implementation that should have been gone. Auth can only be set before connection and we don't support reusing commands or connections at all.
So, instead of adding a new Connect function, I think it would be better to just remove SetAuth from all interfaces (Command, Session) and add transport.AuthMethod as a second parameter to NewUploadPackSession and NewReceivePackSession.
That would keep these interfaces simpler and avoid invalid sequences of function calls.
There was a problem hiding this comment.
Ah, I had wondered about that. I've moved AuthMethod to the PackSession functions now.
While doing that, I noticed that server also uses these functions. I've left a TODO for now to design / implement AuthMethod for servers. I think this could be used to verify a client connection to the go-git server in the future.
Reworks
Commandinterface to split the session creation into two components: general object create & session connect. This allows an external caller to create the session, callSetAuth(), and then perform the network connection. This network connection is "baked" in to the other interface functions to keep the external interface the same.Addresses #206.