Revert decoding of query parameters

HttpRequest, as used by the SDK, does not contain encoded keys or values.
APIGateway's events also contain decoded query string keys and values. The
only thing that needs decoding is path segments, because the path is stored
un-split and thus it cannot be stored decoded (or / and %2F would be
indistinguishable).

This partially reverts 24f2ead

Author: adamthom-amzn

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java

@@ -1689,9 +1689,8 @@ private void readDirectQueryBindings(GenerationContext context, List<HttpBinding
             writer.openBlock("if (query[$S] !== undefined) {", "}", binding.getLocationName(), () -> {
                 Shape target = context.getModel().expectShape(binding.getMember().getTarget());
                 if (target instanceof CollectionShape) {
-                    writer.write("const decoded = Array.isArray(query[$1S]) ? (query[$1S] as string[])"
-                            + ".map(e => decodeURIComponent(e)) : [decodeURIComponent(query[$1S] as string)];",
-                            binding.getLocationName());
+                    writer.write("const queryValue = Array.isArray(query[$1S]) ? (query[$1S] as string[])"
+                            + " : [query[$1S] as string];", binding.getLocationName());
                 } else {
                     writer.addImport("SerializationException",
                             "__SerializationException",
@@ -1701,10 +1700,10 @@ private void readDirectQueryBindings(GenerationContext context, List<HttpBinding
                             () -> {
                                 writer.write("throw new __SerializationException();");
                             });
-                    writer.write("const decoded = decodeURIComponent(query[$1S] as string);",
+                    writer.write("const queryValue = query[$1S] as string;",
                             binding.getLocationName());
                 }
-                String queryValue = getOutputValue(context, binding.getLocation(), "decoded",
+                String queryValue = getOutputValue(context, binding.getLocation(), "queryValue",
                         binding.getMember(), target);
                 writer.write("contents.$L = $L;", memberName, queryValue);
             });
@@ -1721,12 +1720,12 @@ private void readMappedQueryBindings(GenerationContext context, HttpBinding mapp
             valueType = "string[]";
         }
         writer.write("let parsedQuery: { [key: string]: $L } = {}", valueType);
-        String parsedValue = getOutputValue(context, mappedBinding.getLocation(),
-                "decoded", target.getValue(), valueShape);
         writer.openBlock("for (const [key, value] of Object.entries(query)) {", "}", () -> {
+            final String parsedValue;
             if (valueShape instanceof CollectionShape) {
-                writer.write("const decoded = Array.isArray(value) ? (value as string[])"
-                        + ".map(e => decodeURIComponent(e)) : [decodeURIComponent(value as string)];");
+                writer.write("const valueArray = Array.isArray(value) ? (value as string[]) : [value as string];");
+                parsedValue = getOutputValue(context, mappedBinding.getLocation(),
+                        "valueArray", target.getValue(), valueShape);
             } else {
                 writer.addImport("SerializationException",
                         "__SerializationException",
@@ -1735,9 +1734,10 @@ private void readMappedQueryBindings(GenerationContext context, HttpBinding mapp
                         () -> {
                             writer.write("throw new __SerializationException();");
                         });
-                writer.write("const decoded = decodeURIComponent(value as string);");
+                parsedValue = getOutputValue(context, mappedBinding.getLocation(),
+                                "value as string", target.getValue(), valueShape);
             }
-            writer.write("parsedQuery[decodeURIComponent(key)] = $L;", parsedValue);
+            writer.write("parsedQuery[key] = $L;", parsedValue);
         });
         String memberName = context.getSymbolProvider().toMemberName(mappedBinding.getMember());
         writer.write("contents.$L = parsedQuery;", memberName);