Skip to content

Commit 2cef1f6

Browse files
committed
fix(tests): use a fixture for requests version
1 parent 619cba8 commit 2cef1f6

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

tests/conftest.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import importlib.metadata
2+
3+
import pytest
4+
5+
6+
@pytest.fixture
7+
def requests_version() -> str:
8+
return importlib.metadata.version("requests")

tests/test_main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ def test_main_fails(runner: CliRunner) -> None:
2020

2121

2222
def test_retrieve_called_with_auth_headers(
23-
request: pytest.FixtureRequest, runner: CliRunner
23+
request: pytest.FixtureRequest, runner: CliRunner, requests_version: str
2424
) -> None:
2525
if request.config.getoption("typeguard_packages"):
2626
pytest.skip(
2727
"The import hook that typeguard uses seems to break the mock below."
2828
)
2929

3030
expected_headers = {
31-
"User-Agent": "python-requests/2.32.3",
31+
"User-Agent": f"python-requests/{requests_version}",
3232
"Accept-Encoding": "gzip, deflate",
3333
"Accept": "*/*",
3434
"Connection": "keep-alive",

tests/test_validations.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ def sample_item() -> Generator[pystac.Item, None, None]:
4545

4646

4747
@pytest.fixture
48-
def expected_headers() -> Generator[Dict[str, str], None, None]:
48+
def expected_headers(requests_version: str) -> Generator[Dict[str, str], None, None]:
4949
yield {
50-
"User-Agent": "python-requests/2.32.3",
50+
"User-Agent": f"python-requests/{requests_version}",
5151
"Accept-Encoding": "gzip, deflate",
5252
"Accept": "*/*",
5353
"Connection": "keep-alive",

0 commit comments

Comments
 (0)