Skip to content

Commit 2bd40d7

Browse files
committed
Display 'No ASSET request errors\!' only when opening asset URLs
1 parent 1638b9c commit 2bd40d7

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@ STAC Best Practices:
250250

251251
No ASSET format errors!
252252

253-
No ASSET request errors!
254253
This object has 4 links
255254
</pre>
256255
---

stac_check/cli.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,16 @@
66
from .logo import logo
77

88

9-
def link_asset_message(link_list: list, type: str, format: str) -> None:
9+
def link_asset_message(
10+
link_list: list, type: str, format: str, healthy_msg: bool
11+
) -> None:
1012
"""Prints a list of links or assets and any errors associated with them.
1113
1214
Args:
1315
link_list (list): A list of links or assets.
1416
type (str): The type of link or asset being processed.
1517
format (str): The format or request being used.
18+
healthy_msg (bool): Whether to display "No TYPE errors!" or not
1619
1720
Returns:
1821
None.
@@ -21,7 +24,7 @@ def link_asset_message(link_list: list, type: str, format: str) -> None:
2124
click.secho(f"{type.upper()} {format} errors: ", fg="red")
2225
for asset in link_list:
2326
click.secho(f" {asset}")
24-
else:
27+
elif healthy_msg:
2528
click.secho(f"No {type.upper()} {format} errors!", fg="green")
2629

2730

@@ -130,19 +133,21 @@ def cli_message(linter: Linter) -> None:
130133

131134
if linter.invalid_asset_format is not None:
132135
click.secho()
133-
link_asset_message(linter.invalid_asset_format, "asset", "format")
136+
link_asset_message(linter.invalid_asset_format, "asset", "format", True)
134137

135138
if linter.invalid_asset_request is not None:
136139
click.secho()
137-
link_asset_message(linter.invalid_asset_request, "asset", "request")
140+
link_asset_message(
141+
linter.invalid_asset_request, "asset", "request", linter.assets_open_urls
142+
)
138143

139144
if linter.invalid_link_format is not None:
140145
click.secho()
141-
link_asset_message(linter.invalid_link_format, "link", "format")
146+
link_asset_message(linter.invalid_link_format, "link", "format", True)
142147

143148
if linter.invalid_link_request is not None:
144149
click.secho()
145-
link_asset_message(linter.invalid_link_request, "link", "request")
150+
link_asset_message(linter.invalid_link_request, "link", "request", True)
146151

147152
if linter.error_type != "":
148153
click.secho("Validation error type: ", fg="red")

0 commit comments

Comments
 (0)