clean up transactions

Author: jonhealy1

stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/transactions.py

@@ -54,18 +54,8 @@ def _create_item_index(self):
     def create_item(self, model: stac_types.Item, **kwargs):
         """Create item."""
         base_url = str(kwargs["request"].base_url)
-        item_links = ItemLinks(
-            collection_id=model["collection"], item_id=model["id"], base_url=base_url
-        ).create_links()
-        model["links"] = item_links
 
-        # elasticsearch doesn't like the fact that some values are float and some were int
-        if "eo:bands" in model["properties"]:
-            for wave in model["properties"]["eo:bands"]:
-                for k, v in wave.items():
-                    if type(v) != str:
-                        v = float(v)
-                        wave.update({k: v})
+        self._create_item_index()
 
         if not self.client.exists(index="stac_collections", id=model["collection"]):
             raise ForeignKeyError(f"Collection {model['collection']} does not exist")
@@ -75,13 +65,7 @@ def create_item(self, model: stac_types.Item, **kwargs):
                 f"Item {model['id']} in collection {model['collection']} already exists"
             )
 
-        now = datetime.utcnow().strftime(DATETIME_RFC339)
-        if "created" not in model["properties"]:
-            model["properties"]["created"] = str(now)
-
-        self._create_item_index()
-
-        data = ItemSerializer.stac_to_db(model)
+        data = ItemSerializer.stac_to_db(model, base_url)
 
         self.client.index(
             index="stac_items", doc_type="_doc", id=model["id"], document=data
@@ -162,25 +146,25 @@ def __attrs_post_init__(self):
         settings = ElasticsearchSettings()
         self.client = settings.create_client
 
-    def _create_item_index(self):
-        mapping = {
-            "mappings": {
-                "properties": {
-                    "geometry": {"type": "geo_shape"},
-                    "id": {"type": "text", "fields": {"keyword": {"type": "keyword"}}},
-                    "properties__datetime": {
-                        "type": "text",
-                        "fields": {"keyword": {"type": "keyword"}},
-                    },
-                }
-            }
-        }
-
-        _ = self.client.indices.create(
-            index="stac_items",
-            body=mapping,
-            ignore=400,  # ignore 400 already exists code
-        )
+    # def _create_item_index(self):
+    #     mapping = {
+    #         "mappings": {
+    #             "properties": {
+    #                 "geometry": {"type": "geo_shape"},
+    #                 "id": {"type": "text", "fields": {"keyword": {"type": "keyword"}}},
+    #                 "properties__datetime": {
+    #                     "type": "text",
+    #                     "fields": {"keyword": {"type": "keyword"}},
+    #                 },
+    #             }
+    #         }
+    #     }
+
+    #     _ = self.client.indices.create(
+    #         index="stac_items",
+    #         body=mapping,
+    #         ignore=400,  # ignore 400 already exists code
+    #     )
 
     def _preprocess_item(self, model: stac_types.Item, base_url) -> stac_types.Item:
         """Preprocess items to match data model."""
@@ -212,7 +196,8 @@ def _preprocess_item(self, model: stac_types.Item, base_url) -> stac_types.Item:
 
     def bulk_item_insert(self, items: Items, **kwargs) -> str:
         """Bulk item insertion using es."""
-        self._create_item_index()
+        transactions_client = TransactionsClient()
+        transactions_client._create_item_index()
         try:
             base_url = str(kwargs["request"].base_url)
         except Exception: