Skip to content

Commit 1708e8e

Browse files
committed
fix: pass request by name into methods
This makes #22 less breaking.
1 parent 62bd047 commit 1708e8e

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

CHANGES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## [Unreleased]
44

5+
### Fixed
6+
7+
- Pass `request` by name when calling endpoints from other endpoints ([#44](https://github.com/stac-utils/stac-fastapi-pgstac/pull/44))
8+
59
## [2.4.8] - 2023-06-08
610

711
### Changed

stac_fastapi/pgstac/core.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ async def _add_item_links(
213213
if settings.use_api_hydrate:
214214

215215
async def _get_base_item(collection_id: str) -> Dict[str, Any]:
216-
return await self._get_base_item(collection_id, request)
216+
return await self._get_base_item(collection_id, request=request)
217217

218218
base_item_cache = settings.base_item_cache(
219219
fetch_base_item=_get_base_item, request=request
@@ -267,7 +267,7 @@ async def item_collection(
267267
An ItemCollection.
268268
"""
269269
# If collection does not exist, NotFoundError wil be raised
270-
await self.get_collection(collection_id, request)
270+
await self.get_collection(collection_id, request=request)
271271

272272
base_args = {
273273
"collections": [collection_id],
@@ -285,7 +285,7 @@ async def item_collection(
285285
search_request = self.post_request_model(
286286
**clean,
287287
)
288-
item_collection = await self._search_base(search_request, request)
288+
item_collection = await self._search_base(search_request, request=request)
289289
links = await ItemCollectionLinks(
290290
collection_id=collection_id, request=request
291291
).get_links(extra_links=item_collection["links"])
@@ -307,12 +307,12 @@ async def get_item(
307307
Item.
308308
"""
309309
# If collection does not exist, NotFoundError wil be raised
310-
await self.get_collection(collection_id, request)
310+
await self.get_collection(collection_id, request=request)
311311

312312
search_request = self.post_request_model(
313313
ids=[item_id], collections=[collection_id], limit=1
314314
)
315-
item_collection = await self._search_base(search_request, request)
315+
item_collection = await self._search_base(search_request, request=request)
316316
if not item_collection["features"]:
317317
raise NotFoundError(
318318
f"Item {item_id} in Collection {collection_id} does not exist."
@@ -333,7 +333,7 @@ async def post_search(
333333
Returns:
334334
ItemCollection containing items which match the search criteria.
335335
"""
336-
item_collection = await self._search_base(search_request, request)
336+
item_collection = await self._search_base(search_request, request=request)
337337
return ItemCollection(**item_collection)
338338

339339
async def get_search(

0 commit comments

Comments
 (0)