Return 400 for Item id or collection conflicts

Author: duckontheweb

stac_fastapi/pgstac/stac_fastapi/pgstac/transactions.py

@@ -30,7 +30,7 @@ async def create_item(
         body_collection_id = item.get("collection")
         if body_collection_id is not None and collection_id != body_collection_id:
             raise HTTPException(
-                status_code=409,
+                status_code=400,
                 detail=f"Collection ID from path parameter ({collection_id}) does not match Collection ID from Item ({body_collection_id})",
             )
         item["collection"] = collection_id
@@ -46,14 +46,14 @@ async def update_item(
         body_collection_id = item.get("collection")
         if body_collection_id is not None and collection_id != body_collection_id:
             raise HTTPException(
-                status_code=409,
+                status_code=400,
                 detail=f"Collection ID from path parameter ({collection_id}) does not match Collection ID from Item ({body_collection_id})",
             )
         item["collection"] = collection_id
         body_item_id = item["id"]
         if body_item_id != item_id:
             raise HTTPException(
-                status_code=409,
+                status_code=400,
                 detail=f"Item ID from path parameter ({item_id}) does not match Item ID from Item ({body_item_id})",
             )
         request = kwargs["request"]

stac_fastapi/pgstac/tests/resources/test_item.py

@@ -86,7 +86,7 @@ async def test_create_item(app_client, load_test_data: Callable, load_test_colle
 async def test_create_item_mismatched_collection_id(
     app_client, load_test_data: Callable, load_test_collection
 ):
-    # If the collection_id path parameter and the Item's "collection" property do not match, a 409 response should
+    # If the collection_id path parameter and the Item's "collection" property do not match, a 400 response should
     # be returned.
     coll = load_test_collection
 
@@ -98,7 +98,7 @@ async def test_create_item_mismatched_collection_id(
         f"/collections/{coll.id}/items",
         json=in_json,
     )
-    assert resp.status_code == 409
+    assert resp.status_code == 400
 
 
 async def test_fetches_valid_item(
@@ -166,7 +166,7 @@ async def test_update_item_mismatched_collection_id(
         f"/collections/{coll.id}/items/{item_id}",
         json=in_json,
     )
-    assert resp.status_code == 409
+    assert resp.status_code == 400
 
 
 async def test_delete_item(

stac_fastapi/sqlalchemy/stac_fastapi/sqlalchemy/transactions.py

@@ -54,7 +54,7 @@ def create_item(
         body_collection_id = item.get("collection")
         if body_collection_id is not None and collection_id != body_collection_id:
             raise HTTPException(
-                status_code=409,
+                status_code=400,
                 detail=f"Collection ID from path parameter ({collection_id}) does not match Collection ID from Item ({body_collection_id})",
             )
         item["collection"] = collection_id
@@ -80,14 +80,14 @@ def update_item(
         body_collection_id = item.get("collection")
         if body_collection_id is not None and collection_id != body_collection_id:
             raise HTTPException(
-                status_code=409,
+                status_code=400,
                 detail=f"Collection ID from path parameter ({collection_id}) does not match Collection ID from Item ({body_collection_id})",
             )
         item["collection"] = collection_id
         body_item_id = item["id"]
         if body_item_id != item_id:
             raise HTTPException(
-                status_code=409,
+                status_code=400,
                 detail=f"Item ID from path parameter ({item_id}) does not match Item ID from Item ({body_item_id})",
             )
         base_url = str(kwargs["request"].base_url)