fix search, next, and prev media types (#393)

* update root POST /search link, next, and prev links to use application/geojson instead of application/json

* pre-commit fixup

Author: Phil Varner

stac_fastapi/pgstac/stac_fastapi/pgstac/models/links.py

@@ -125,15 +125,15 @@ def link_next(self) -> Optional[Dict[str, Any]]:
                 href = merge_params(self.url, {"token": f"next:{self.next}"})
                 link = dict(
                     rel=Relations.next.value,
-                    type=MimeTypes.json.value,
+                    type=MimeTypes.geojson.value,
                     method=method,
                     href=href,
                 )
                 return link
             if method == "POST":
                 return {
                     "rel": Relations.next,
-                    "type": MimeTypes.json,
+                    "type": MimeTypes.geojson,
                     "method": method,
                     "href": f"{self.request.url}",
                     "body": {**self.request.postbody, "token": f"next:{self.next}"},
@@ -149,14 +149,14 @@ def link_prev(self) -> Optional[Dict[str, Any]]:
                 href = merge_params(self.url, {"token": f"prev:{self.prev}"})
                 return dict(
                     rel=Relations.previous.value,
-                    type=MimeTypes.json.value,
+                    type=MimeTypes.geojson.value,
                     method=method,
                     href=href,
                 )
             if method == "POST":
                 return {
                     "rel": Relations.previous,
-                    "type": MimeTypes.json,
+                    "type": MimeTypes.geojson,
                     "method": method,
                     "href": f"{self.request.url}",
                     "body": {**self.request.postbody, "token": f"prev:{self.prev}"},

stac_fastapi/pgstac/tests/resources/test_conformance.py

@@ -1,4 +1,5 @@
 import urllib.parse
+from typing import Dict, Optional
 
 import pytest
 
@@ -9,13 +10,18 @@ async def response(app_client):
 
 
 @pytest.fixture(scope="module")
-async def response_json(response):
+async def response_json(response) -> Dict:
     return response.json()
 
 
-def get_link(landing_page, rel_type):
+def get_link(landing_page, rel_type, method: Optional[str] = None):
     return next(
-        filter(lambda link: link["rel"] == rel_type, landing_page["links"]), None
+        filter(
+            lambda link: link["rel"] == rel_type
+            and (not method or link.get("method") == method),
+            landing_page["links"],
+        ),
+        None,
     )
 
 
@@ -41,7 +47,7 @@ def test_landing_page_health(response):
 @pytest.mark.asyncio
 @pytest.mark.parametrize("rel_type,expected_media_type,expected_path", link_tests)
 async def test_landing_page_links(
-    response_json, app_client, rel_type, expected_media_type, expected_path
+    response_json: Dict, app_client, rel_type, expected_media_type, expected_path
 ):
     link = get_link(response_json, rel_type)
 
@@ -59,11 +65,13 @@ async def test_landing_page_links(
 # code here seems meaningless since it would be the same as if the endpoint did not exist. Once
 # https://github.com/stac-utils/stac-fastapi/pull/227 has been merged we can add this to the
 # parameterized tests above.
-def test_search_link(response_json):
-    search_link = get_link(response_json, "search")
-
-    assert search_link is not None
-    assert search_link.get("type") == "application/geo+json"
-
-    search_path = urllib.parse.urlsplit(search_link.get("href")).path
-    assert search_path == "/search"
+def test_search_link(response_json: Dict):
+    for search_link in [
+        get_link(response_json, "search", "GET"),
+        get_link(response_json, "search", "POST"),
+    ]:
+        assert search_link is not None
+        assert search_link.get("type") == "application/geo+json"
+
+        search_path = urllib.parse.urlsplit(search_link.get("href")).path
+        assert search_path == "/search"

stac_fastapi/types/stac_fastapi/types/core.py

@@ -278,7 +278,7 @@ def _landing_page(
                 },
                 {
                     "rel": Relations.search.value,
-                    "type": MimeTypes.json,
+                    "type": MimeTypes.geojson,
                     "title": "STAC search",
                     "href": urljoin(base_url, "search"),
                     "method": "POST",