Skip to content

Commit bf924d7

Browse files
committed
fix: code review
1 parent 4317768 commit bf924d7

File tree

4 files changed

+12
-25
lines changed

4 files changed

+12
-25
lines changed

.github/actions/resolve-release-version/action.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,4 @@ runs:
1313
- name: Resolve release version
1414
id: resolve-release-version
1515
shell: bash
16-
run: >
17-
echo "$(
18-
node -e "
19-
const fs = require('fs');
20-
const pkg = fs.readFileSync('./packages/astro/package.json', 'utf8');
21-
const version = JSON.parse(pkg).version
22-
console.log('version=' + version);
23-
"
24-
)" >> $GITHUB_OUTPUT
16+
run: echo "version=$(jq -r .version ./packages/astro/package.json)" >> $GITHUB_OUTPUT

.github/workflows/integration-test-cli.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ name: Integration Tests CLI
22

33
on:
44
pull_request:
5+
workflow_dispatch:
56

67
jobs:
78
cli-integration-test:

.github/workflows/prepare-release.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,17 @@ jobs:
2525
run: >
2626
pnpm --recursive
2727
--filter "@tutorialkit/*"
28-
--filter create-tutorial
2928
exec pnpm version --no-git-tag-version --allow-same-version ${{ inputs.version }}
3029
3130
- name: Generage changelog
32-
run: |
33-
pnpm run changelog
34-
git checkout ./packages/cli
31+
run: pnpm run changelog
3532

3633
- name: Create Pull Request
3734
uses: peter-evans/create-pull-request@v6
3835
with:
3936
# Note: `publish-release.yaml` checks explicitly for this commit message
40-
commit-message: 'chore: release @tutorialkit packages and create-tutorial, version: ${{ inputs.version }}'
41-
title: 'chore: release @tutorialkit packages and create-tutorial, version: ${{ inputs.version }}'
37+
commit-message: 'chore: release @tutorialkit packages, version: ${{ inputs.version }}'
38+
title: 'chore: release @tutorialkit packages, version: ${{ inputs.version }}'
4239
body: 'Bump packages to version ${{ inputs.version }} and generate changelogs'
4340
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio
4441
branch: chore/release-${{ inputs.version }}

.github/workflows/publish-release.yaml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ jobs:
3030
run: >
3131
pnpm --recursive
3232
--filter "@tutorialkit/*"
33-
--filter create-tutorial
3433
exec pnpm publish --provenance
3534
env:
3635
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
@@ -62,22 +61,16 @@ jobs:
6261
run: >
6362
pnpm --recursive
6463
--filter tutorialkit
64+
--filter create-tutorial
6565
exec npm version --no-git-tag-version --allow-same-version ${{ steps.resolve-release-version.outputs.version }}
6666
67-
- name: Generage changelog
68-
run: |
69-
pnpm run changelog
70-
git add ./packages/cli ./packages/template
71-
git checkout ./packages
72-
git checkout CHANGELOG.md
73-
7467
- name: Create Pull Request
7568
uses: peter-evans/create-pull-request@v6
7669
with:
7770
# Note: `publish-release.yaml` checks explicitly for this commit message
7871
commit-message: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
7972
title: 'chore: release tutorialkit CLI, version: ${{ steps.resolve-release-version.outputs.version }}'
80-
body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }} and generate changelog'
73+
body: 'Bump tutorialkit CLI to version ${{ steps.resolve-release-version.outputs.version }}'
8174
reviewers: SamVerschueren,d3lm,Nemikolh,AriPerkkio
8275
branch: chore/release-cli-${{ steps.resolve-release-version.outputs.version }}
8376

@@ -106,6 +99,10 @@ jobs:
10699
run: pnpm test
107100

108101
- name: Publish to npm
109-
run: pnpm --recursive --filter tutorialkit exec pnpm publish --provenance
102+
run: >
103+
pnpm --recursive
104+
--filter tutorialkit
105+
--filter create-tutorial
106+
exec pnpm publish --provenance
110107
env:
111108
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

0 commit comments

Comments
 (0)