fix: feedback

Author: Nemikolh

packages/astro/src/default/utils/url.ts

@@ -1,5 +1,5 @@
-export function joinPaths(baseURL: string, ...paths: string[]): string {
-  let result = baseURL || '/';
+export function joinPaths(basePath: string, ...paths: string[]): string {
+  let result = basePath || '/';
 
   for (const subpath of paths) {
     if (subpath.length === 0) {

packages/runtime/src/lesson-files.spec.ts

@@ -38,7 +38,7 @@ describe('LessonFilesFetcher', () => {
   test('getLessonTemplate should fetch at a different pathname if the fetcher is configured to use a different base', async () => {
     fetchBody = { 'a.txt': 'content' };
 
-    const fetcher = new LessonFilesFetcher('/foo/');
+    const fetcher = new LessonFilesFetcher('/foo');
     const files = await fetcher.getLessonTemplate({ data: { template: 'default' } } as any);
 
     expect(files).toEqual({ 'a.txt': 'content' });

packages/runtime/src/lesson-files.ts

@@ -14,15 +14,11 @@ export class LessonFilesFetcher {
   private _templateLoadTask?: Task<Files>;
   private _templateLoaded: string | undefined;
 
-  /**
-   * Create a new instance of the LessonFilesFetcher.
-   *
-   * This class is responsible for fetching lesson files and templates.
-   * It caches the files in memory to avoid fetching them multiple times.
-   *
-   * @param _basePathname The base pathname to use when fetching files.
-   */
-  constructor(private _basePathname: string = '/') {}
+  constructor(private _basePathname: string = '/') {
+    if (!this._basePathname.endsWith('/')) {
+      this._basePathname = this._basePathname + '/';
+    }
+  }
 
   async invalidate(filesRef: string): Promise<InvalidationResult> {
     if (!this._map.has(filesRef)) {