Add support for EFI boot mode (#7)

* Install OVMF package
* Upgrade qemu-kvm on RedHat

Author: jovial

README.md

@@ -39,6 +39,8 @@ default value is `true`.
 system emulators, e.g.  `x86`. The default value is `['x86']` if
 `libvirt_host_require_vt` is `false`, otherwise the default value is an empty
 list.
+`libvirt_vm_enable_efi_support`: Whether to enable EFI support. This defaults 
+to false as extra packages need to be installed.
 
 Dependencies
 ------------

defaults/main.yml

@@ -25,3 +25,7 @@ libvirt_host_require_vt: true
 
 # List of architectures for which to install QEMU system emulators, e.g. x86.
 libvirt_host_qemu_emulators: "{{ [] if libvirt_host_require_vt | bool else ['x86'] }}"
+
+# Whether or not to enable UEFI support. In some cases this requires installing
+# extra packages.
+libvirt_host_enable_efi_support: false

tasks/install.yml

@@ -8,6 +8,19 @@
     - "{{ ansible_os_family }}.yml"
   tags: vars
 
+- name: Install custom yum repositories
+  # Although argument splatting is marked as deprecated:
+  #
+  # [DEPRECATION WARNING]: Using variables for task params is unsafe,
+  # especially if the variables come from an external source like facts. This
+  # feature will be removed in a future release.
+  #
+  # The core team had a a change of heart and it is actually being preserved:
+  # https://github.com/ansible/ansible/pull/43798
+  yum_repository: "{{ item }}"
+  loop: "{{ libvirt_host_custom_yum_repos | default([]) }}"
+  become: true
+
 - name: Ensure libvirt packages are installed
   package:
     name: "{{ item }}"

vars/Debian.yml

@@ -1,7 +1,17 @@
 ---
 # List of libvirt package dependencies.
-libvirt_host_libvirt_packages:
+libvirt_host_libvirt_packages_default:
   - libvirt-bin
   - qemu-kvm
   - python-libvirt
   - python-lxml
+
+# Packages that are only necessary if you require EFI support
+libvirt_host_packages_efi:
+  - ovmf
+
+# List of all packages to install
+libvirt_host_libvirt_packages: >
+  {{ libvirt_host_libvirt_packages_default +
+     (libvirt_host_packages_efi if libvirt_host_enable_efi_support else []) | unique
+  }}

vars/RedHat.yml

@@ -1,8 +1,34 @@
 ---
 # List of libvirt package dependencies.
-libvirt_host_libvirt_packages:
+libvirt_host_libvirt_packages_default:
   - libvirt
   - libvirt-daemon-kvm
   - libvirt-python
   - python-lxml
   - qemu-kvm
+
+# Packages that are only necessary if you require EFI support
+libvirt_host_packages_efi:
+  - edk2.git-ovmf-x64 # Official OVMF package doesn't boot (CentOS 7.5)
+  - qemu-kvm-ev # Need smm support for secure boot
+
+# List of all packages to install
+libvirt_host_libvirt_packages: >
+  {{ libvirt_host_libvirt_packages_default +
+     (libvirt_host_packages_efi if libvirt_host_enable_efi_support else []) | unique
+  }}
+
+libvirt_host_custom_yum_repos_efi:
+  # Add custom repository as OVMF package seems to be broken
+  - name: qemu-firmware-jenkins
+    description: upstream OVMF firmware images
+    baseurl: https://www.kraxel.org/repos/jenkins/
+    gpgcheck: no
+  # Need an updated version of qemu with smm support
+  - name: centos-qemu-ev
+    description: CentOS-$releasever - QEMU EV
+    baseurl: http://mirror.centos.org/$contentdir/$releasever/virt/$basearch/kvm-common/
+    gpgcheck: yes
+
+libvirt_host_custom_yum_repos: "{{ libvirt_host_custom_yum_repos_efi if libvirt_host_enable_efi_support else [] | unique }}"
+