Merge pull request #10 from stackhpc/lint

Fix lint issues

Author: markgoddard

tasks/config.yml

@@ -8,7 +8,7 @@
     regexp: '^unix_sock_dir ='
     line: unix_sock_dir = "{{ libvirt_host_socket_dir }}"
   become: true
-  when: libvirt_host_socket_dir != ""
+  when: libvirt_host_socket_dir | length > 0
   notify: restart libvirt
 
 - name: Create directory for libvirt socket
@@ -19,7 +19,7 @@
     group: root
     mode: 0755
   become: true
-  when: libvirt_host_socket_dir != ""
+  when: libvirt_host_socket_dir | length > 0
 
 - name: Process lineinfile rules
   lineinfile: "{{ rule.args }}"

tasks/install.yml

@@ -14,16 +14,21 @@
 
 - name: Ensure libvirt packages are installed
   package:
-    name: "{{ item }}"
+    name: "{{ libvirt_host_libvirt_packages }}"
     state: installed
-  with_items: "{{ libvirt_host_libvirt_packages }}"
+  register: result
+  until: result is success
+  retries: 3
   become: True
 
 # NOTE: QEMU emulators are available in EPEL.
 - name: Ensure the EPEL repository is enabled
   yum:
     name: epel-release
     state: installed
+  register: result
+  until: result is success
+  retries: 3
   become: True
   when:
     - ansible_os_family == "RedHat"
@@ -34,6 +39,9 @@
     name: "{{ package }}"
     state: installed
   with_items: "{{ libvirt_host_qemu_emulators }}"
+  register: result
+  until: result is success
+  retries: 3
   become: True
   vars:
     package: "qemu-system-{{ item }}"

tasks/prelude.yml

@@ -4,7 +4,7 @@
 - name: gather os specific variables
   include_vars: "{{ item }}"
   with_first_found:
-    - "{{ ansible_distribution }}-{{ ansible_distribution_major_version}}.yml"
+    - "{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml"
     - "{{ ansible_distribution }}.yml"
     - "{{ ansible_os_family }}.yml"
   tags: vars