Move package installation to stackhpc.libvirt-host role

See: stackhpc/ansible-role-libvirt-host#7

Author: jovial

README.md

@@ -27,12 +27,6 @@ Role Variables
 
 - `libvirt_vm_arch`: CPU architecture, default is `x86_64`.
 
-- `libvirt_vm_enable_efi_support`: Whether to enable EFI support. By default this
-  will enabled if any of the declared VMs specify the boot_firmware as efi. The
-  certificates and keys needed to enable secure boot are currently only installed
-  on RedHat derived distributions. See: [qemu-ovmf-secureboot](https://github.com/puiterwijk/qemu-ovmf-secureboot)
-  for details of the certificates and keys that are installed.
-
 - `libvirt_vms`: list of VMs to be created/destroyed. Each one may have the
   following attributes:
 

defaults/main.yml

@@ -34,9 +34,6 @@ libvirt_ovmf_vars_generator_output_path: /var/lib/libvirt/qemu/
 # Prefix of generated variable file name. The checksum of the input will be appended.
 libvirt_ovmf_vars_generator_output_prefix: ovmf_vars_enrolled_
 
-# Whether to enable EFI support.
-libvirt_vm_enable_efi_support: "{{ 'efi' in (libvirt_vms | map(attribute='boot_firmware') | map('lower')) }}"
-
 # A list of specifications of VMs to be created.
 # For backwards compatibility, libvirt_vms defaults to a singleton list using
 # the values of the deprecated variables below.

tasks/main.yml

@@ -1,7 +1,5 @@
 ---
 
-- include_tasks: setup.yml
-
 - include_tasks: autodetect.yml
   # We don't need to know the engine and emulator if we're not creating any new
   # VMs.

tasks/setup.yml

@@ -7,13 +7,6 @@ libvirt_vm_qemu_user: libvirt-qemu
 # The environment passed to virt_volume.sh
 libvirt_vm_volume_creation_env: {}
 
-# Packages that are only necessary if you require EFI support
-libvirt_vm_extra_packages_efi:
-  - ovmf
-
-# List of extra packages to install
-libvirt_vm_extra_packages: "{{ libvirt_vm_extra_packages_efi if libvirt_vm_enable_efi_support else [] | unique }}"
-
 # Path to template OVMF efi variable store. A copy will be created
 # for each VM created.
 libvirt_vm_ovmf_efi_variable_store_path: /usr/share/OVMF/OVMF_VARS.fd

vars/Debian.yml

@@ -9,14 +9,6 @@ libvirt_vm_volume_creation_env:
   VOLUME_GROUP: qemu
   VOLUME_OWNER: qemu
 
-# Packages that are only necessary if you require EFI support
-libvirt_vm_extra_packages_efi:
-  - edk2.git-ovmf-x64 # Official OVMF package doesn't boot (CentOS 7.5)
-  - qemu-kvm-ev # Need smm support for secure boot
-
-# List of extra packages to install
-libvirt_vm_extra_packages: "{{ libvirt_vm_extra_packages_efi if libvirt_vm_enable_efi_support else [] | unique }}"
-
 # Path to template OVMF efi variable store. A copy will be created
 # for each VM created.
 # note(wszumski): official package path is /usr/share/OVMF/OVMF_VARS.fd
@@ -30,17 +22,3 @@ libvirt_vm_ovmf_efi_firmware_path: /usr/share/edk2.git/ovmf-x64/OVMF_CODE-need-s
 # note(wszumski): official package path is /usr/share/OVMF/UefiShell.iso
 libvirt_vm_ovmf_uefi_shell_iso_path: /usr/share/edk2.git/ovmf-x64/UefiShell.iso
 
-# Add custom repository as OVMF package seems to be broken
-libvirt_vm_custom_yum_repos_efi:
-  - name: qemu-firmware-jenkins
-    description: upstream OVMF firmware images
-    baseurl: https://www.kraxel.org/repos/jenkins/
-    gpgcheck: no
-  # Need an updated version of qemu with smm support
-  - name: centos-qemu-ev
-    description: CentOS-$releasever - QEMU EV
-    baseurl: http://mirror.centos.org/$contentdir/$releasever/virt/$basearch/kvm-common/
-    gpgcheck: yes
-
-libvirt_vm_custom_yum_repos: "{{ libvirt_vm_custom_yum_repos_efi if libvirt_vm_enable_efi_support else [] | unique }}"
-