Skip to content

Commit 4ef0c82

Browse files
authored
Merge pull request #637 from stackhpc/extra-list
Allow empty items in extra package and user lists
2 parents 6b800fd + b66fefa commit 4ef0c82

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

environments/common/inventory/group_vars/all/defaults.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ appliances_local_users_default:
4242
home: /var/lib/{{ appliances_local_users_ansible_user_name }}
4343
move_home: true
4444
local: true
45-
45+
4646
- user: "{{ appliances_local_users_podman }}"
4747
enable: "{{ 'podman' in group_names }}"
4848

@@ -53,7 +53,7 @@ appliances_local_users_default:
5353
shell: /sbin/nologin
5454
uid: 202
5555
system: true
56-
56+
5757
- group:
5858
name: prometheus
5959
gid: 976
@@ -64,7 +64,7 @@ appliances_local_users_default:
6464
shell: /usr/sbin/nologin
6565
system: true
6666
enable: "{{ 'prometheus' in group_names }}"
67-
67+
6868
- group:
6969
name: grafana
7070
gid: 979
@@ -79,7 +79,7 @@ appliances_local_users_default:
7979

8080
# Overide this to add extra users whilst keeping the defaults.
8181
appliances_local_users_extra: [] # see format of appliances_local_users_default above
82-
appliances_local_users: "{{ appliances_local_users_default + appliances_local_users_extra }}"
82+
appliances_local_users: "{{ (appliances_local_users_default + appliances_local_users_extra) | select | list }}"
8383

8484
################## bootstrap: extra package installs ######################################
8585

@@ -94,7 +94,7 @@ appliances_extra_packages_default:
9494
- postfix
9595
- git
9696
- "{{ 'python36' if ansible_distribution_version == '8.9' else 'python312' }}"
97-
97+
9898
appliances_extra_packages_other: []
99-
100-
appliances_extra_packages: "{{ appliances_extra_packages_default + appliances_extra_packages_other }}"
99+
100+
appliances_extra_packages: "{{ (appliances_extra_packages_default + appliances_extra_packages_other) | select | list }}"

environments/common/inventory/group_vars/all/openhpc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ openhpc_packages_default:
2828
- apptainer
2929
- podman-compose
3030
openhpc_packages_extra: []
31-
openhpc_packages: "{{ openhpc_packages_default + openhpc_packages_extra }}"
31+
openhpc_packages: "{{ (openhpc_packages_default + openhpc_packages_extra) | select | list }}"
3232
openhpc_munge_key: "{{ vault_openhpc_mungekey | b64decode }}"
3333
openhpc_login_only_nodes: login
3434
openhpc_config_default:

0 commit comments

Comments
 (0)