Skip to content

Commit 4fee13c

Browse files
committed
update rules comments
1 parent 43f4a87 commit 4fee13c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

ansible/roles/alertmanager/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ In general usage may only require:
2424
- Enabling the Slack integration (see section below).
2525
- Possibly setting `alertmanager_web_external_url`.
2626

27+
TODO: explain where alertmanager web GUI is
28+
2729
## Role variables
2830

2931
All variables are optional. See [defaults/main.yml](defaults/main.yml) for
@@ -156,3 +158,7 @@ Some ideas for future alerts which could be useful:
156158
- smartctl-exporter-based rules for baremetal nodes where the is no
157159
infrastructure-level smart monitoring
158160
- loss of "up" network interfaces
161+
162+
163+
TODO: suggest awesome alerts
164+
TODO: note that child env rule files override parent envs

environments/common/inventory/group_vars/all/prometheus.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ prometheus_alertmanager_config_default:
1515
- "{{ alertmanager_address }}:{{ alertmanager_port }}"
1616
prometheus_alertmanager_config: "{{ prometheus_alertmanager_config_default if groups['alertmanager'] else {} }}"
1717

18-
# by default, use rule files from the following path relative to current and all parent environment inventory directories:
18+
# By default, find rule files from the following path relative to current and all parent environment inventory directories:
19+
# Note: If the same file exists in parent and child environments, only the file in the latter has any effect.
1920
prometheus_alert_rules_files_inventory_glob: ../files/prometheus/rules/*.rules
2021
prometheus_alert_rules_files: "{{ ansible_inventory_sources | product([prometheus_alert_rules_files_inventory_glob]) | map('join', '/') | map('realpath') }}"
21-
# TODO: find a way to include/exclude files?
2222

2323
prometheus_alert_rules: []
2424

0 commit comments

Comments
 (0)