Remove support for setting VNIC binding profiles

This should not be required anymore and resolves an issue where, after
creating a Neutron port of baremetal VNIC type, OpenTofu wants to revert
its profile to an empty dict even though it was populated with
local_link_information.

Author: priteau

environments/skeleton/{{cookiecutter.environment}}/tofu/compute.tf

@@ -16,7 +16,6 @@ module "compute" {
   # can be set for group, defaults to top-level value:
   image_id = lookup(each.value, "image_id", var.cluster_image_id)
   vnic_types = lookup(each.value, "vnic_types", var.vnic_types)
-  vnic_profiles = lookup(each.value, "vnic_profiles", var.vnic_profiles)
   volume_backed_instances = lookup(each.value, "volume_backed_instances", var.volume_backed_instances)
   root_volume_size = lookup(each.value, "root_volume_size", var.root_volume_size)
 

environments/skeleton/{{cookiecutter.environment}}/tofu/control.tf

@@ -18,7 +18,6 @@ resource "openstack_networking_port_v2" "control" {
 
   binding {
     vnic_type = lookup(var.vnic_types, each.key, "normal")
-    profile = lookup(var.vnic_profiles, each.key, "{}")
   }
 }
 

environments/skeleton/{{cookiecutter.environment}}/tofu/login.tf

@@ -16,7 +16,6 @@ module "login" {
   # can be set for group, defaults to top-level value:
   image_id = lookup(each.value, "image_id", var.cluster_image_id)
   vnic_types = lookup(each.value, "vnic_types", var.vnic_types)
-  vnic_profiles = lookup(each.value, "vnic_profiles", var.vnic_profiles)
   volume_backed_instances = lookup(each.value, "volume_backed_instances", var.volume_backed_instances)
   root_volume_size = lookup(each.value, "root_volume_size", var.root_volume_size)
 

environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/nodes.tf

@@ -49,7 +49,6 @@ resource "openstack_networking_port_v2" "compute" {
 
   binding {
     vnic_type = lookup(var.vnic_types, each.value.network, "normal")
-    profile = lookup(var.vnic_profiles, each.value.network, "{}")
   }
 }
 

environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/variables.tf

@@ -37,11 +37,6 @@ variable "vnic_types" {
     default = {}
 }
 
-variable "vnic_profiles" {
-    type = map(string)
-    default = {}
-}
-
 variable "volume_backed_instances" {
     description = "Whether to use volumes for root disks"
     type = bool

environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf

@@ -45,7 +45,6 @@ variable "login" {
         image_id: Overrides variable cluster_image_id
         extra_networks: List of mappings in same format as cluster_networks
         vnic_type: Overrides variable vnic_type
-        vnic_profile: Overrides variable vnic_profile
         volume_backed_instances: Overrides variable volume_backed_instances
         root_volume_size: Overrides variable root_volume_size
         extra_volumes: Mapping defining additional volumes to create and attach
@@ -85,7 +84,6 @@ variable "compute" {
             image_id: Overrides variable cluster_image_id
             extra_networks: List of mappings in same format as cluster_networks
             vnic_type: Overrides variable vnic_type
-            vnic_profile: Overrides variable vnic_profile
             compute_init_enable: Toggles compute-init rebuild (see compute-init role docs)
             ignore_image_changes: Ignore changes to the image_id parameter (see docs/experimental/compute-init.md)
             volume_backed_instances: Overrides variable volume_backed_instances
@@ -144,16 +142,6 @@ variable "vnic_types" {
     default = {}
 }
 
-variable "vnic_profiles" {
-    type = map(string)
-    description = <<-EOT
-    Default VNIC binding profiles, keyed by network name. Values are json strings.
-    See https://registry.terraform.io/providers/terraform-provider-openstack/openstack/latest/docs/resources/networking_port_v2#profile.
-    If not given this defaults to "{}"
-    EOT
-    default = {}
-}
-
 variable "login_security_groups" {
     type = list(string)
     description = "Name of preexisting security groups to apply to login nodes"