Skip to content

Commit f2df57b

Browse files
author
scrungus
committed
remove comments, storage network renamed
1 parent 4b5a792 commit f2df57b

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

ansible/roles/cluster_infra/templates/resources.tf.j2

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ data "openstack_networking_network_v2" "cluster_external_network" {
116116
name = "{{ cluster_external_network }}"
117117
}
118118

119-
# SRIOV storage network
119+
# Storage network
120120
{% if cluster_storage_network is defined %}
121-
data "openstack_networking_network_v2" "cluster_storage_direct" {
121+
data "openstack_networking_network_v2" "cluster_storage" {
122122
name = "{{ cluster_storage_network }}"
123123
}
124124
{% endif %}
@@ -217,15 +217,13 @@ resource "openstack_networking_port_v2" "login" {
217217
{% if cluster_storage_network is defined %}
218218
resource "openstack_networking_port_v2" "login_storage" {
219219
name = "{{ cluster_name }}-login-storage-0"
220-
network_id = data.openstack_networking_network_v2.cluster_storage_direct.id
220+
network_id = data.openstack_networking_network_v2.cluster_storage.id
221221
admin_state_up = "true"
222222

223-
# not sure if needed here
224223
security_group_ids = [
225224
"${openstack_networking_secgroup_v2.secgroup_slurm_cluster.id}",
226225
]
227226

228-
# for now, until we set up flavors
229227
binding {
230228
vnic_type = "{{ cluster_storage_vnic_type | default('normal') }}"
231229
}
@@ -260,19 +258,17 @@ resource "openstack_networking_port_v2" "control" {
260258
}
261259
}
262260

263-
# Storage VLAN
261+
# Storage network
264262
{% if cluster_storage_network is defined %}
265263
resource "openstack_networking_port_v2" "control_storage" {
266264
name = "{{ cluster_name }}-control-storage-0"
267-
network_id = data.openstack_networking_network_v2.cluster_storage_direct.id
265+
network_id = data.openstack_networking_network_v2.cluster_storage.id
268266
admin_state_up = "true"
269267

270-
# not sure if needed here
271268
security_group_ids = [
272269
"${openstack_networking_secgroup_v2.secgroup_slurm_cluster.id}"
273270
]
274271

275-
# for now, until we set up flavors
276272
binding {
277273
vnic_type = "{{ cluster_storage_vnic_type | default('normal') }}"
278274
}
@@ -308,20 +304,18 @@ resource "openstack_networking_port_v2" "{{ partition.name }}" {
308304
}
309305
}
310306

311-
# Storage VLAN
307+
# Storage network
312308
{% if cluster_storage_network is defined %}
313309
resource "openstack_networking_port_v2" "{{ partition.name }}_storage" {
314310
count = {{ partition.count }}
315311
name = "{{ cluster_name }}-compute-{{ partition.name }}-storage-${count.index}"
316-
network_id = data.openstack_networking_network_v2.cluster_storage_direct.id
312+
network_id = data.openstack_networking_network_v2.cluster_storage.id
317313
admin_state_up = "true"
318314

319-
# not sure if needed here
320315
security_group_ids = [
321316
"${openstack_networking_secgroup_v2.secgroup_slurm_cluster.id}"
322317
]
323318

324-
# for now, until we set up flavors
325319
binding {
326320
vnic_type = "{{ cluster_storage_vnic_type | default('normal') }}"
327321
}

0 commit comments

Comments
 (0)