Remove 'nova.virt.libvirt.compat'

This contained a single wrapper for 'domain.info()' that worked around a
race in libvirt 1.2.11. We haven't supported this version for quite some
time [1] so the module itself can go.

[1] http://git.openstack.org/cgit/openstack/nova/commit/?id=28d337b --
    Pick next minimum libvirt / QEMU versions for "Stein"

Change-Id: I690d64c01accb10afc2ff20844e2d51bfa68e635
Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

nova/tests/unit/virt/libvirt/test_compat.py

@@ -9273,8 +9273,7 @@ def get_instance_diagnostics(self, instance):
         # TODO(sahid): Needs to use get_info but more changes have to
         # be done since a mapping STATE_MAP LIBVIRT_POWER_STATE is
         # needed.
-        (state, max_mem, mem, num_cpu, cpu_time) = \
-            guest._get_domain_info(self._host)
+        state, max_mem, mem, num_cpu, cpu_time = guest._get_domain_info()
         config_drive = configdrive.required_by(instance)
         launched_at = timeutils.normalize_time(instance.launched_at)
         uptime = timeutils.delta_seconds(launched_at,

nova/virt/libvirt/compat.py

@@ -42,7 +42,6 @@
 from nova.i18n import _
 import nova.privsep.libvirt
 from nova.virt import hardware
-from nova.virt.libvirt import compat
 from nova.virt.libvirt import config as vconfig
 
 libvirt = None
@@ -513,16 +512,12 @@ def set_user_password(self, user, new_pass):
         """Configures a new user password."""
         self._domain.setUserPassword(user, new_pass, 0)
 
-    def _get_domain_info(self, host):
-        """Returns information on Guest
-
-        :param host: a host.Host object with current
-                     connection. Unfortunately we need to pass it
-                     because of a workaround with < version 1.2..11
+    def _get_domain_info(self):
+        """Returns information on Guest.
 
         :returns list: [state, maxMem, memory, nrVirtCpu, cpuTime]
         """
-        return compat.get_domain_info(libvirt, host, self._domain)
+        return self._domain.info()
 
     def get_info(self, host):
         """Retrieve information from libvirt for a specific instance name.
@@ -534,7 +529,7 @@ def get_info(self, host):
         :returns hardware.InstanceInfo:
         """
         try:
-            dom_info = self._get_domain_info(host)
+            dom_info = self._get_domain_info()
         except libvirt.libvirtError as ex:
             error_code = ex.get_error_code()
             if error_code == libvirt.VIR_ERR_NO_DOMAIN:

nova/virt/libvirt/driver.py

@@ -909,7 +909,7 @@ def _sum_domain_memory_mb(self, include_host=True):
         for guest in self.list_guests(only_guests=False):
             try:
                 # TODO(sahid): Use get_info...
-                dom_mem = int(guest._get_domain_info(self)[2])
+                dom_mem = int(guest._get_domain_info()[2])
             except libvirt.libvirtError as e:
                 LOG.warning("couldn't obtain the memory from domain:"
                             " %(uuid)s, exception: %(ex)s",