Skip to content

Commit 18ba6e6

Browse files
author
Eric Fried
committed
Skip test_check_doubled_words hacking check UT
The referenced bug has reared its ugly head in python 2.7.15 in (at least) releaselevel='final', which is being used in the gate, as well as 3.6.7+. Disable the test entirely until we can fix or work around the bug in the tokenizer. The hacking check itself is still in place. This is just disabling the unit test that tries to test the hacking check. NOTE: Noticed that the hacking check is operating on physical_line, which means it'll catch things like: "This is the the error" but not: ("This is the " "the error") ...which is probably way more likely. Change-Id: I8826c3fb89690805baae6b9b7b48985abb8d62d3 Related-Bug: #1804062
1 parent e8b6b0b commit 18ba6e6

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

nova/tests/unit/test_hacking.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
# License for the specific language governing permissions and limitations
1313
# under the License.
1414

15-
import sys
1615
import textwrap
1716

1817
import mock
@@ -581,9 +580,8 @@ def test_check_config_option_in_central_place(self):
581580

582581
# TODO(cdent): Remove when https://bugs.launchpad.net/nova/+bug/1804062
583582
# is resolved.
584-
@testtools.skipIf(
585-
sys.version_info[0:3] >= (3, 6, 7),
586-
'tokenize has backwards incompatible behavior from 3.6.7')
583+
@testtools.skip(
584+
'tokenize has backwards incompatible behavior from 3.6.7 and 2.7.15')
587585
def test_check_doubled_words(self):
588586
errors = [(1, 0, "N343")]
589587

0 commit comments

Comments
 (0)