Skip to content

Commit 7058fac

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Update contributor guide for Ussuri"
2 parents 66d1764 + 6901be6 commit 7058fac

File tree

2 files changed

+14
-76
lines changed

2 files changed

+14
-76
lines changed

doc/source/contributor/how-to-get-involved.rst

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@ downvoted. There is also the :ref:`code-review`. Once you have some
5555
understanding, start reviewing patches. It's OK to ask people to explain things
5656
you don't understand. It's also OK to see some potential problems but put a +0.
5757

58-
Another way is to look for a subteam you'd like to get involved with and review
59-
their patches. See:
60-
https://etherpad.openstack.org/p/train-nova-subteam-tracking
61-
6258
Once you're ready to write code, take a look at some of the work already marked
6359
as low-hanging fruit:
6460

@@ -215,15 +211,16 @@ really helps you:
215211

216212
- Doing more reviews, and seeing what other reviewers notice, will help
217213
you better understand what is expected of code that gets merged into
218-
master
214+
master.
219215
- Having more non-core people do great reviews, leaves less review work
220-
for the core reviewers to do, so we are able get more code merged
216+
for the core reviewers to do, so we are able get more code merged.
221217
- Empathy is one of the keys to a happy community. If you are used to
222218
doing code reviews, you will better understand the comments you get
223219
when people review your code. As you do more code reviews, and see
224220
what others notice, you will get a better idea of what people are
225221
looking for when then apply a +2 to your code.
226-
- TODO - needs more detail
222+
- If you do quality reviews, you'll be noticed and it's more likely
223+
you'll get reciprocal eyes on your reviews.
227224

228225
What are the most useful types of code review comments? Well here are a
229226
few to the top ones:
@@ -264,7 +261,7 @@ reviews:
264261
- Where do I start? What should I review?
265262

266263
- There are various tools, but a good place to start is:
267-
https://etherpad.openstack.org/p/train-nova-subteam-tracking
264+
https://etherpad.openstack.org/p/nova-runways-ussuri
268265
- Depending on the time in the cycle, it's worth looking at
269266
NeedsCodeReview blueprints:
270267
https://blueprints.launchpad.net/nova/
@@ -326,7 +323,7 @@ becoming a member of nova-core.
326323
How to do great nova-spec reviews?
327324
==================================
328325

329-
https://specs.openstack.org/openstack/nova-specs/specs/train/template.html
326+
https://specs.openstack.org/openstack/nova-specs/specs/ussuri/template.html
330327

331328
:doc:`/contributor/blueprints`.
332329

doc/source/contributor/process.rst

Lines changed: 8 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ If you are new to Nova, please read this first: :ref:`getting_involved`.
3636
Dates overview
3737
==============
3838

39-
For Train, please see:
40-
https://wiki.openstack.org/wiki/Nova/Train_Release_Schedule
39+
For Ussuri, please see:
40+
https://wiki.openstack.org/wiki/Nova/Ussuri_Release_Schedule
4141

4242
.. note: Throughout this document any link which references the name of a
4343
release cycle in the link can usually be changed to the name of the
@@ -102,9 +102,9 @@ Why we have a Spec Freeze:
102102

103103
By the freeze date, we expect all blueprints that will be approved for the
104104
cycle to be listed on launchpad and all relevant specs to be merged.
105-
For Train, blueprints can be found at
106-
https://blueprints.launchpad.net/nova/train and specs at
107-
https://specs.openstack.org/openstack/nova-specs/specs/train/index.html
105+
For Ussuri, blueprints can be found at
106+
https://blueprints.launchpad.net/nova/ussuri and specs at
107+
https://specs.openstack.org/openstack/nova-specs/specs/ussuri/index.html
108108

109109
Starting with Liberty, we are keeping a backlog open for submission at all
110110
times.
@@ -125,59 +125,6 @@ yourself available to discuss the blueprint, or alternatively make your
125125
case on the ML before the meeting):
126126
https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
127127

128-
Non-priority Feature Freeze
129-
~~~~~~~~~~~~~~~~~~~~~~~~~~~
130-
131-
This is a Nova specific process.
132-
133-
This only applies to low priority blueprints in this list:
134-
https://blueprints.launchpad.net/nova/train
135-
136-
We currently have a very finite amount of review bandwidth. In order to
137-
make code review time for the agreed community wide priorities, we have
138-
to not do some other things. In each cycle, milestones are used to bound
139-
when certain types of work will be active and reviewed and to avoid crushing
140-
the gate with too much code near the end of the cycle.
141-
142-
For example, in the Liberty cycle, we reserved the liberty-3 milestone for
143-
priority features and bug fixes and did not merge any non-priority things
144-
during liberty-3. This meant that liberty-2 was the "Feature Freeze" for
145-
blueprints that were not a priority for the Liberty cycle.
146-
147-
You can see the list of priorities for each release:
148-
http://specs.openstack.org/openstack/nova-specs/#priorities
149-
150-
For things that are very close to merging, it's possible to request an
151-
exception for one week after the freeze date, given the patches get
152-
enough +2s from the core team to get the code merged. But we expect this
153-
list to be zero, if everything goes to plan (no massive gate failures,
154-
etc). For history of the process see:
155-
http://lists.openstack.org/pipermail/openstack-dev/2015-July/070920.html
156-
157-
Exception process:
158-
159-
- Please add request in here:
160-
https://etherpad.openstack.org/p/train-nova-non-priority-feature-freeze
161-
(ideally with core reviewers to sponsor your patch, normally the
162-
folks who have already viewed those patches)
163-
- make sure you make your request before the end of the feature freeze
164-
exception period
165-
- nova-drivers will meet to decide what gets an exception (for some history
166-
see:
167-
http://lists.openstack.org/pipermail/openstack-dev/2015-February/056208.html)
168-
- an initial list of exceptions (probably just a `PTL`_ compiled list at
169-
that point) will be available for discussion during the next Nova meeting
170-
- the aim is to merge the code for all exceptions early in the following week
171-
172-
Alternatives:
173-
174-
- It was hoped to make this a continuous process using "slots" to
175-
control what gets reviewed, but this was rejected by the community
176-
when it was last discussed. There is hope this can be resurrected to
177-
avoid the "lumpy" nature of this process.
178-
- Currently the runways/kanban ideas are blocked on us adopting
179-
something like phabricator that could support such workflows
180-
181128
String Freeze
182129
~~~~~~~~~~~~~
183130

@@ -382,8 +329,6 @@ blueprint-only features:
382329
For blueprint and spec features, do everything for blueprint-only
383330
features and also:
384331

385-
- If it's a project or subteam priority, add it to:
386-
https://etherpad.openstack.org/p/train-nova-subteam-tracking
387332
- Ensure your spec is approved for the current release cycle.
388333

389334
If your code is a project or subteam priority, the cores interested in
@@ -786,13 +731,9 @@ merge greater strength. In addition, having the subteam focus review efforts
786731
on a subset of patches should help concentrate the nova-core reviews they
787732
get, and increase the velocity of getting code merged.
788733

789-
The first part is for subgroups to show they can do a great job of
790-
recommending patches. This is starting in here:
791-
https://etherpad.openstack.org/p/train-nova-subteam-tracking
792-
793-
Ideally this would be done with gerrit user "tags" rather than an
794-
etherpad. There are some investigations by sdague in how feasible it
795-
would be to add tags to gerrit.
734+
Ideally this would be done with gerrit user "tags".
735+
There are some investigations by sdague in how feasible it would be to add
736+
tags to gerrit.
796737

797738
Stop having to submit a spec for each release
798739
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

0 commit comments

Comments
 (0)