Skip to content

Commit 8223a84

Browse files
author
Balazs Gibizer
committed
Remove no-op fake calls from network_info tests
Stephen pointed out during the review of I4bdd25458998ca1a9fb411dfd015684a6d3fcfa3 that there are unnecessary calls in the network_info unit tests. So this patch now drop these. Change-Id: I5f9611e0d2eb212aaec299d27a4a29e6f7e3199c
1 parent 779fd5e commit 8223a84

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

nova/tests/unit/network/test_network_info.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
class RouteTests(test.NoDBTestCase):
2929
def test_create_route_with_attrs(self):
3030
route = fake_network_cache_model.new_route()
31-
fake_network_cache_model.new_ip(dict(address='192.168.1.1'))
3231
self.assertEqual('0.0.0.0/24', route['cidr'])
3332
self.assertEqual('192.168.1.1', route['gateway']['address'])
3433
self.assertEqual('eth0', route['interface'])
@@ -332,8 +331,6 @@ def test_network_not_equal(self):
332331
self.assertNotEqual(network1, network2)
333332

334333
def test_hydrate(self):
335-
fake_network_cache_model.new_subnet()
336-
fake_network_cache_model.new_subnet(dict(cidr='255.255.255.255'))
337334
network = model.Network.hydrate(fake_network_cache_model.new_network())
338335

339336
self.assertEqual(1, network['id'])
@@ -449,7 +446,6 @@ def test_vif_get_labeled_ips(self):
449446
self.assertEqual(ip_dict, labeled_ips)
450447

451448
def test_hydrate(self):
452-
fake_network_cache_model.new_network()
453449
vif = model.VIF.hydrate(fake_network_cache_model.new_vif())
454450
self.assertEqual(1, vif['id'])
455451
self.assertEqual('aa:aa:aa:aa:aa:aa', vif['address'])

0 commit comments

Comments
 (0)