api: Handle invalid volume UUIDs during spawn

If a user requests an invalid volume UUID when creating an instance,
a 'VolumeNotFound' exception will be raised. This is not currently
handled. Correct this.

Change-Id: I6137dc1b6b51321fee1c080bf4b85197b19bf223
Signed-off-by: Stephen Finucane <[email protected]>
Closes-Bug: #1930448

Author: stephenfin

nova/api/openstack/compute/servers.py

@@ -731,6 +731,7 @@ def create(self, req, body):
                 exception.FlavorNotFound,
                 exception.InvalidMetadata,
                 exception.InvalidVolume,
+                exception.VolumeNotFound,
                 exception.MismatchVolumeAZException,
                 exception.MultiplePortsNotApplicable,
                 exception.InvalidFixedIpAndMaxCountRequest,

nova/tests/unit/api/openstack/compute/test_servers.py

@@ -6957,6 +6957,14 @@ def test_create_instance_with_invalid_volume_error(self, create_mock):
         self.assertRaises(webob.exc.HTTPBadRequest,
                           self._test_create_extra, {})
 
+    @mock.patch.object(
+        compute_api.API, 'create',
+        side_effect=exception.VolumeNotFound(volume_id='foo'))
+    def test_create_instance_with_volume_not_found_error(self, create_mock):
+        # Tests that InvalidVolume is translated to a 400 error.
+        self.assertRaises(
+            webob.exc.HTTPBadRequest, self._test_create_extra, {})
+
 
 class ServersViewBuilderTest(test.TestCase):
     project_id = fakes.FAKE_PROJECT_ID