Skip to content

Commit bc19a33

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Fix misleading documentation for live_migration_inbound_addr"
2 parents 1d241a1 + b6e9023 commit bc19a33

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

nova/conf/libvirt.py

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@
222222
"""),
223223
cfg.StrOpt('live_migration_scheme',
224224
help="""
225-
URI scheme used for live migration.
225+
URI scheme for live migration used by the source of live migration traffic.
226226
227227
Override the default libvirt live migration scheme (which is dependent on
228228
virt_type). If this option is set to None, nova will automatically choose a
@@ -238,7 +238,11 @@
238238
"""),
239239
cfg.HostAddressOpt('live_migration_inbound_addr',
240240
help="""
241-
Target used for live migration traffic.
241+
IP address used as the live migration address for this host.
242+
243+
This option indicates the IP address which should be used as the target for
244+
live migration traffic when migrating to this hypervisor. This metadata is then
245+
used by the source of the live migration traffic to construct a migration URI.
242246
243247
If this option is set to None, the hostname of the migration target compute
244248
node will be used.
@@ -247,11 +251,6 @@
247251
impact the network plane significantly. A separate network for live-migration
248252
traffic can then use this config option and avoids the impact on the
249253
management network.
250-
251-
Related options:
252-
253-
* ``live_migration_tunnelled``: The live_migration_inbound_addr value is
254-
ignored if tunneling is enabled.
255254
"""),
256255
cfg.StrOpt('live_migration_uri',
257256
deprecated_for_removal=True,
@@ -262,11 +261,11 @@
262261
and ``live_migration_inbound_addr`` respectively.
263262
""",
264263
help="""
265-
Live migration target URI to use.
264+
Live migration target URI used by the source of live migration traffic.
266265
267266
Override the default libvirt live migration target URI (which is dependent
268267
on virt_type). Any included "%s" is replaced with the migration target
269-
hostname.
268+
hostname, or `live_migration_inbound_addr` if set.
270269
271270
If this option is set to None (which is the default), Nova will automatically
272271
generate the `live_migration_uri` value based on only 4 supported `virt_type`
@@ -300,11 +299,6 @@
300299
impact performance massively.
301300
302301
Note that this option is NOT compatible with use of block migration.
303-
304-
Related options:
305-
306-
* ``live_migration_inbound_addr``: The live_migration_inbound_addr value is
307-
ignored if tunneling is enabled.
308302
"""),
309303
cfg.IntOpt('live_migration_bandwidth',
310304
default=0,

0 commit comments

Comments
 (0)