Remove '/os-cells' REST APIs

Drop support for the os-cells REST APIs, which are part of the cells v1
feature which has been deprecated since Pike.

This API now returns a 410 response for all routes.

Unit tests are removed and the functional API sample tests are just
asserting the 410 response now. The latter are also expanded to cover
APIs that weren't previously tested.

The API sample docs are left intact since the API reference still builds
from those and can be considered more or less branchless, so people
looking at the API reference can apply it to older deployments of nova
before os-cells was removed.

A release note added for previous cells v1 removals is amended to note
this additional change.

Part of blueprint remove-cells-v1

Change-Id: Iddb519008515f591cf1d884872a5887afbe766f2
Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

api-ref/source/index.rst

@@ -73,7 +73,6 @@ limited to some maximum microversion.
 .. include:: os-security-group-default-rules.inc
 .. include:: os-security-group-rules.inc
 .. include:: os-hosts.inc
-.. include:: os-cells.inc
 
 =============
 Obsolete APIs
@@ -89,3 +88,4 @@ Compute API in the past, but no longer exist.
 .. include:: os-fixed-ips.inc
 .. include:: os-floating-ips-bulk.inc
 .. include:: os-floating-ip-dns.inc
+.. include:: os-cells.inc

api-ref/source/os-cells.inc

@@ -1,8 +1,4 @@
 .. -*- rst -*-
-.. needs:parameter_verification
-.. needs:example_verification
-.. needs:body_verification
-
 
 ==============================
  Cells (os-cells, capacities)
@@ -11,10 +7,13 @@
 Adds neighbor cells, lists neighbor cells, and shows the capabilities of
 the local cell. By default, only administrators can manage cells.
 
-.. warning:: These APIs refer to a Cells v1 deployment which was deprecated
-  in the 16.0.0 Pike release. These are not used with Cells v2
-  which is required beginning with the 15.0.0 Ocata release where all Nova
-  deployments consist of at least one Cells v2 cell.
+.. warning::
+
+   These APIs refer to a Cells v1 deployment which was deprecated in the 16.0.0
+   Pike release. These are not used with Cells v2 which is required beginning
+   with the 15.0.0 Ocata release where all Nova deployments consist of at least
+   one Cells v2 cell.
+   They were removed in the 20.0.0 Train release.
 
 List Cells
 ==========
@@ -26,7 +25,7 @@ Lists cells.
 Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-NotImplemented(501)
+gone(410), notImplemented(501)
 
 Request
 -------
@@ -52,10 +51,10 @@ Create Cell
 
 Create a new cell.
 
-Normal response code: 200
+Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-NotImplemented(501)
+gone(410), notImplemented(501)
 
 Capacities
 ==========
@@ -64,8 +63,10 @@ Capacities
 
 Retrieve capacities.
 
+Normal response codes: 200
+
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-NotImplemented(501)
+gone(410), notImplemented(501)
 
 List Cells With Details
 =======================
@@ -77,7 +78,7 @@ Lists cells with details of capabilities.
 Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-NotImplemented(501)
+gone(410), notImplemented(501)
 
 Request
 -------
@@ -94,10 +95,10 @@ Info For This Cell
 
 Retrieve info about the current cell.
 
-Normal response code: 200
+Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-NotImplemented(501)
+gone(410), notImplemented(501)
 
 Show Cell Data
 ==============
@@ -109,7 +110,7 @@ Shows data for a cell.
 Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-itemNotFound(404), NotImplemented(501)
+itemNotFound(404), gone(410), notImplemented(501)
 
 Request
 -------
@@ -129,15 +130,15 @@ Response
 Update a Cell
 =============
 
-.. rest_method:: PUT /os-cells/{cell_od}
+.. rest_method:: PUT /os-cells/{cell_id}
 
 
 Update an existing cell.
 
-Normal response code: 200
+Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-itemNotFound(404), NotImplemented(501)
+itemNotFound(404), gone(410), notImplemented(501)
 
 Delete a Cell
 =============
@@ -146,10 +147,10 @@ Delete a Cell
 
 Remove a cell.
 
-Normal response code: 200
+Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-itemNotFound(404), NotImplemented(501)
+itemNotFound(404), gone(410), notImplemented(501)
 
 Show Cell Capacities
 ====================
@@ -158,10 +159,10 @@ Show Cell Capacities
 
 Shows capacities for a cell.
 
-Normal response codes: 200,501
+Normal response codes: 200
 
 Error response codes: badRequest(400), unauthorized(401), forbidden(403),
-itemNotFound(404), NotImplemented(501)
+itemNotFound(404), gone(410), notImplemented(501)
 
 Request
 -------

doc/api_samples/os-cells/cells-list-empty-resp.json

@@ -14,7 +14,6 @@
 #    under the License.
 
 import collections
-import functools
 import itertools
 import re
 
@@ -495,15 +494,6 @@ def get_flavor(context, flavor_id):
         raise exc.HTTPNotFound(explanation=error.format_message())
 
 
-def check_cells_enabled(function):
-    @functools.wraps(function)
-    def inner(*args, **kwargs):
-        if not CONF.cells.enable:
-            raise_feature_not_supported()
-        return function(*args, **kwargs)
-    return inner
-
-
 def is_all_tenants(search_opts):
     """Checks to see if the all_tenants flag is in search_opts