Merge "Fix incorrect masquerade rules in multivip LBs"

Author: Zuul

octavia/amphorae/backends/utils/interface.py

@@ -356,11 +356,10 @@ def _rules_up(self, interface, ipr, idx):
                               **rule)
 
     def _scripts_up(self, interface, current_state):
-        if current_state == consts.IFACE_DOWN:
-            for script in interface.scripts[consts.IFACE_UP]:
-                LOG.debug("%s: Running command '%s'",
-                          interface.name, script[consts.COMMAND])
-                subprocess.check_output(script[consts.COMMAND].split())
+        for script in interface.scripts[consts.IFACE_UP]:
+            LOG.debug("%s: Running command '%s'",
+                      interface.name, script[consts.COMMAND])
+            subprocess.check_output(script[consts.COMMAND].split())
 
     def down(self, interface):
         LOG.info("Setting interface %s down", interface.name)

octavia/tests/unit/amphorae/backends/utils/test_interface.py

@@ -714,7 +714,9 @@ def test_up_update(self, mock_wait_tentative, mock_check_output,
                       table=254,
                       family=socket.AF_INET)])
 
-        mock_check_output.assert_not_called()
+        mock_check_output.assert_has_calls([
+            mock.call(["post-up", "eth1"])
+        ])
 
     @mock.patch('pyroute2.IPRoute.rule')
     @mock.patch('pyroute2.IPRoute.route')

releasenotes/notes/fix-missing-masquerade-rules-in-dualstack-lbs-94f97606c5804b36.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixed an issue when using UDP listeners in dual-stack (IPv4 and IPv6) load
+    balancers, some masquerade rules needed by UDP were not correctly set on the
+    member interfaces.