DNM: FIXMEs, TODOs, general musings

Author: markgoddard

.automation

@@ -14,6 +14,8 @@ When configured, an image will be downloaded to the seed during the
 ``kayobe seed service deploy`` step, and subsequently deployed using bifrost
 with ``kayobe overcloud provision``.
 
+FIXME: Should we do this by default in Zed+?
+
 To use these images, set ``stackhpc_download_overcloud_host_images`` to true
 in ``etc/kayobe/stackhpc-overcloud-host-images.yml``.
 
@@ -44,17 +46,16 @@ StackHPC Kayobe configuration provides configuration for some standard
 overcloud host images, built using the :kayobe-doc:`overcloud DIB
 <configuration/reference/overcloud-dib.html>` functionality of Kayobe.
 
+FIXME:
+
 The overcloud DIB configuration is provided in
-``etc/kayobe/stackhpc-overcloud-dib.yml``. It is not used by default, and must
-be actively opted into. This can be done as follows:
+``etc/kayobe/stackhpc-overcloud-dib.yml``. It is used by default, but may be
+opted out of as follows:
 
 .. code-block:: yaml
    :caption: ``etc/kayobe/overcloud-dib.yml``
 
-   overcloud_dib_build_host_images: true
-
-   overcloud_dib_host_images:
-     - "{{ stackhpc_overcloud_dib_host_image }}"
+   overcloud_dib_build_host_images: false
 
 The image name is configured via ``stackhpc_overcloud_dib_name``, and is
 ``deployment_image`` by default.

doc/source/configuration/host-images.rst

@@ -62,6 +62,7 @@ proxy:
    ---
    # HTTP proxy URL (format: http(s)://[user:password@]proxy_name:port). By
    # default no proxy is used.
+   # FIXME: Need to apply the fix from 0e66f0b3dd08b470acb593977dce7dcb611cf5e3
    http_proxy: "http://{{ admin_oc_net_name | net_ip(inventory_hostname=groups['seed'][0]) }}:3128"
 
    # HTTPS proxy URL (format: http(s)://[user:password@]proxy_name:port). By
@@ -73,6 +74,7 @@ proxy:
    # docker_registry) | urlsplit('hostname') }}"] if docker_registry is set, or
    # ["127.0.0.1", "localhost"] otherwise. This is configured only if either
    # http_proxy or https_proxy is set.
+   # FIXME: Need to apply the fix from 0e66f0b3dd08b470acb593977dce7dcb611cf5e3
    no_proxy:
      - "127.0.0.1"
      - "localhost"

doc/source/configuration/walled-garden.rst

@@ -61,6 +61,7 @@ Install package dependencies when on Ubuntu:
 .. parsed-literal::
 
    sudo apt update
+   # FIXME: Stop using virtualenv?
    sudo apt install -y python3-virtualenv
 
 Clone the Kayobe and Kayobe configuration repositories (this one):

doc/source/contributor/environments/ci-aio.rst

@@ -25,6 +25,8 @@ Access the host via SSH.
 
 Install package dependencies.
 
+FIXME: Stop using virtualenv?
+
 On CentOS:
 
 .. parsed-literal::

doc/source/contributor/environments/ci-builder.rst

@@ -24,6 +24,7 @@ $PULP_HOST
 EOF
 
 # Install git and tmux.
+# FIXME: Drop virtualenv?
 if $(which dnf 2>/dev/null >/dev/null); then
     sudo dnf -y install git tmux python3-virtualenv
 else

etc/kayobe/environments/aufn-ceph/a-universe-from-nothing.sh

@@ -277,6 +277,7 @@ kolla_build_customizations_common:
   ironic_inspector_pip_packages_append:
     - /additions/*
 
+# FIXME
 kolla_build_customizations_rocky: # TODO: Check whether this is actually correct. It seems that it was previously being skipped for rocky
   base_yum_repo_files_remove:
     - proxysql.repo

etc/kayobe/kolla.yml

@@ -1,5 +1,6 @@
 ---
 # Overcloud host image versioning tags
 # These images must be in SMS, since they are used by our AIO CI runners
+# FIXME: build & update tags
 stackhpc_rocky_9_overcloud_host_image_version: "yoga-20230515T145140"
 stackhpc_ubuntu_jammy_overcloud_host_image_version: "yoga-20230609T120720"

etc/kayobe/pulp-host-image-versions.yml

@@ -3,6 +3,7 @@
 # Release train overcloud host image sources
 
 # Whether or not to download overcloud host images from Ark
+# TODO: Should we do it by default?
 stackhpc_download_overcloud_host_images: false
 
 # Whether or not to use images with MLNX_OFED installed (for deployment using