Skip to content

Commit 574a9c3

Browse files
authored
Merge pull request #455 from stackhpc/bugfix/hardware-overview-dash
Fix temperature graph on hardware overview dash
2 parents 37c3ace + 2aa4703 commit 574a9c3

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

etc/kayobe/kolla/config/grafana/dashboards/openstack/hardware_overview.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@
530530
},
531531
"editorMode": "code",
532532
"exemplar": false,
533-
"expr": "smartmon_temperature_case_raw_value{instance=~\"$node\"}",
533+
"expr": "smartmon_temperature_case_raw_value{instance=~\"$node\"} or smartmon_temperature_celsius_raw_value{instance=~\"$node\"}",
534534
"format": "table",
535535
"hide": false,
536536
"instant": true,
@@ -664,7 +664,7 @@
664664
},
665665
"editorMode": "code",
666666
"exemplar": false,
667-
"expr": "avg_over_time(smartmon_temperature_case_raw_value{instance=~\"$node\"}[1h])",
667+
"expr": "avg_over_time(smartmon_temperature_case_raw_value{instance=~\"$node\"}[1h]) or avg_over_time(smartmon_temperature_celsius_raw_value{instance=~\"$node\"}[1h])",
668668
"instant": false,
669669
"interval": "",
670670
"legendFormat": "{{instance}} - {{disk}} - {{serial_number}}",
@@ -752,4 +752,4 @@
752752
"version": 5,
753753
"weekStart": ""
754754
}
755-
{% endraw %}
755+
{% endraw %}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
fixes:
3+
- |
4+
Fixes the hardware overview dashboard to use the correct metric for
5+
displaying drive temps. Now uses an `or` to display whichever metric
6+
is compatible with the drives in the system. The two metrics are
7+
temperature_case_raw_value and temperature_celsius_raw_value.

0 commit comments

Comments
 (0)