Ansible-lint revert line-length limit

Author: Alex-Welsh

.github/workflows/stackhpc-pull-request.yml

@@ -96,7 +96,7 @@ jobs:
 
       - name: Linting code 🧪
         run: |
-          ansible-lint -v --force-color -x no-changed-when,risky-file-permissions,run-once,name[template],package-latest,yaml,role-name[path] etc/kayobe/ansible/.
+          ansible-lint -v --force-color -x no-changed-when,risky-file-permissions,run-once,name[template],package-latest,yaml,role-name[path],yaml[line-length] etc/kayobe/ansible/.
 
   # A skipped job is treated as success when used as a required status check.
   # The registered required status checks refer to the name of the job in the

etc/kayobe/ansible/build-ofed-rocky.yml

@@ -42,8 +42,7 @@
 
     - name: Add DOCA host repository package
       ansible.builtin.dnf:
-        name: "https://developer.nvidia.com/downloads/networking/secure/doca-sdk/DOCA_2.8/doca-host-2.8.0-204000_\
-              {{ stackhpc_pulp_doca_ofed_version }}_rhel9{{ stackhpc_pulp_repo_rocky_9_minor_version }}.x86_64.rpm"
+        name: "https://developer.nvidia.com/downloads/networking/secure/doca-sdk/DOCA_2.8/doca-host-2.8.0-204000_{{ stackhpc_pulp_doca_ofed_version }}_rhel9{{ stackhpc_pulp_repo_rocky_9_minor_version }}.x86_64.rpm"
         disable_gpg_check: true
 
     - name: Install DOCA extra packages

etc/kayobe/ansible/deploy-os-capacity-exporter.yml

@@ -31,18 +31,12 @@
 
     - name: Set facts for admin credentials
       ansible.builtin.set_fact:
-        stackhpc_os_capacity_auth_url: "{{ credential.stdout_lines | select('match', '.*OS_AUTH_URL*.') \
-                                        | first | split('=') | last | replace(\"'\", '') }}"
-        stackhpc_os_capacity_project_name: "{{ credential.stdout_lines | select('match', '.*OS_PROJECT_NAME*.') \
-                                        | first | split('=') | last | replace(\"'\", '') }}"
-        stackhpc_os_capacity_domain_name: "{{ credential.stdout_lines | select('match', '.*OS_PROJECT_DOMAIN_NAME*.') \
-                                        | first | split('=') | last | replace(\"'\", '') }}"
-        stackhpc_os_capacity_openstack_region_name: "{{ credential.stdout_lines | select('match', '.*OS_REGION_NAME*.') \
-                                        | first | split('=') | last | replace(\"'\", '') }}"
-        stackhpc_os_capacity_username: "{{ credential.stdout_lines | select('match', '.*OS_USERNAME*.') \
-                                        | first | split('=') | last | replace(\"'\", '') }}"
-        stackhpc_os_capacity_password: "{{ credential.stdout_lines | select('match', '.*OS_PASSWORD*.') \
-                                        | first | split('=') | last | replace(\"'\", '') }}"
+        stackhpc_os_capacity_auth_url: "{{ credential.stdout_lines | select('match', '.*OS_AUTH_URL*.') first | split('=') | last | replace(\"'\", '') }}"
+        stackhpc_os_capacity_project_name: "{{ credential.stdout_lines | select('match', '.*OS_PROJECT_NAME*.') first | split('=') | last | replace(\"'\", '') }}"
+        stackhpc_os_capacity_domain_name: "{{ credential.stdout_lines | select('match', '.*OS_PROJECT_DOMAIN_NAME*.') first | split('=') | last | replace(\"'\", '') }}"
+        stackhpc_os_capacity_openstack_region_name: "{{ credential.stdout_lines | select('match', '.*OS_REGION_NAME*.') first | split('=') | last | replace(\"'\", '') }}"
+        stackhpc_os_capacity_username: "{{ credential.stdout_lines | select('match', '.*OS_USERNAME*.') first | split('=') | last | replace(\"'\", '') }}"
+        stackhpc_os_capacity_password: "{{ credential.stdout_lines | select('match', '.*OS_PASSWORD*.') first | split('=') | last | replace(\"'\", '') }}"
       when: stackhpc_enable_os_capacity
 
     - name: Template clouds.yml

etc/kayobe/ansible/run-container-hotfix.yml

@@ -21,6 +21,5 @@
         index_var: index
 
 - name: Run container_hotfix_command
-  ansible.builtin.command: "{{ kolla_container_engine | default('docker') }} exec \
-                            {{ '-u 0' if container_hotfix_become else '' }} {{ hotfix_container }} {{ container_hotfix_command }}"
+  ansible.builtin.command: "{{ kolla_container_engine | default('docker') }} exec {{ '-u 0' if container_hotfix_become else '' }} {{ hotfix_container }} {{ container_hotfix_command }}"
   when: container_hotfix_command

etc/kayobe/ansible/vault-deploy-overcloud.yml

@@ -89,8 +89,7 @@
       vars:
         vault_api_addr: https://{{ internal_net_name | net_ip }}:8200
         vault_unseal_token: "{{ vault_keys.root_token }}"
-        vault_unseal_ca_cert: "{{ '/etc/pki/tls/certs/ca-bundle.crt' if ansible_facts.os_family == 'RedHat' \
-                               else '/usr/local/share/ca-certificates/OS-TLS-ROOT.crt' }}"
+        vault_unseal_ca_cert: "{{ '/etc/pki/tls/certs/ca-bundle.crt' if ansible_facts.os_family == 'RedHat' else '/usr/local/share/ca-certificates/OS-TLS-ROOT.crt' }}"
         vault_unseal_keys: "{{ vault_keys.keys_base64 }}"
       environment:
         https_proxy: ""

etc/kayobe/ansible/vault-deploy-seed.yml

@@ -77,8 +77,7 @@
           - common_name: "{% if kolla_internal_fqdn != kolla_internal_vip_address %}{{ kolla_internal_fqdn }}{% else %}overcloud{% endif %}"
             role: "{{ seed_vault_pki_role_name }}"
             extra_params:
-              ip_sans: "{% for host in groups['controllers'] %}{{ internal_net_name | net_ip(host) }}\
-                        {% if not loop.last %},{% endif %}{% endfor %},{{ kolla_internal_vip_address }}"
+              ip_sans: "{% for host in groups['controllers'] %}{{ internal_net_name | net_ip(host) }}{% if not loop.last %},{% endif %}{% endfor %},{{ kolla_internal_vip_address }}"
         vault_pki_write_certificate_files: true
         vault_pki_write_pem_bundle: false
         vault_pki_write_int_ca_to_file: true

etc/kayobe/ansible/vault-unseal-overcloud.yml

@@ -31,8 +31,7 @@
       vars:
         vault_api_addr: https://{{ internal_net_name | net_ip }}:8200
         vault_unseal_token: "{{ vault_keys.root_token }}"
-        vault_unseal_ca_cert: "{{ '/etc/pki/tls/certs/ca-bundle.crt' if ansible_facts.os_family == 'RedHat' \
-                               else '/usr/local/share/ca-certificates/OS-TLS-ROOT.crt' }}"
+        vault_unseal_ca_cert: "{{ '/etc/pki/tls/certs/ca-bundle.crt' if ansible_facts.os_family == 'RedHat' else '/usr/local/share/ca-certificates/OS-TLS-ROOT.crt' }}"
         vault_unseal_keys: "{{ vault_keys.keys_base64 }}"
       environment:
         https_proxy: ""