Apply suggestions from code review

Co-authored-by: Matt Crees <[email protected]>

Author: Alex-Welsh

.ansible-lint-ignore

@@ -1,4 +1,4 @@
-# This file contains ignores rule violations for ansible-lint
+# This file contains ignores to rule violations for ansible-lint
 etc/kayobe/ansible/vault-deploy-barbican.yml fqcn[action-core]
 etc/kayobe/ansible/vault-generate-backend-tls.yml fqcn[action-core]
 etc/kayobe/ansible/vault-generate-internal-tls.yml fqcn[action-core]

.github/workflows/stackhpc-pull-request.yml

@@ -96,7 +96,7 @@ jobs:
 
       - name: Linting code 🧪
         run: |
-          ansible-lint -v --force-color -x no-changed-when,risky-file-permissions,run-once,name[template],package-latest,yaml,role-name[path],yaml[line-length] etc/kayobe/ansible/.
+          ansible-lint -v --force-color etc/kayobe/ansible/.
 
   # A skipped job is treated as success when used as a required status check.
   # The registered required status checks refer to the name of the job in the

etc/kayobe/ansible/cephadm-commands-post.yml

@@ -7,7 +7,7 @@
     - cephadm
     - cephadm-commands
   tasks:
-    - name: Apply Cephadm role
+    - name: Apply Cephadm commands role
       ansible.builtin.import_role:
         name: stackhpc.cephadm.commands
       vars:

etc/kayobe/ansible/cephadm-commands-pre.yml

@@ -7,7 +7,7 @@
     - cephadm
     - cephadm-commands
   tasks:
-    - name: Apply Cephadm role
+    - name: Apply Cephadm commands role
       ansible.builtin.import_role:
         name: stackhpc.cephadm.commands
       vars:

etc/kayobe/ansible/cephadm.yml

@@ -6,7 +6,7 @@
 - name: Import Cephadm commands pre playbook
   import_playbook: cephadm-commands-pre.yml
 
-- name: Import Cephadm ec profiles playbook
+- name: Import Cephadm EC profiles playbook
   import_playbook: cephadm-ec-profiles.yml
 
 - name: Import Cephadm crush rules playbook

etc/kayobe/ansible/fix-houston.yml

@@ -20,6 +20,7 @@
   tasks:
     - name: Include kolla-ansible host vars
       ansible.builtin.include_vars: "{{ kolla_config_path }}/inventory/overcloud/host_vars/{{ inventory_hostname }}"
+
     - name: Create systemd service for -ovs network interface
       ansible.builtin.template:
         src: fix-houston-interface.service.j2
@@ -31,7 +32,7 @@
       notify: reload systemd
 
     - name: Enable and start systemd service for -ovs network interface
-      ansible.builtin.systemd:  # noqa command-instead-of-module
+      ansible.builtin.systemd:
         name: fix-houston-{{ item }}
         enabled: true
         state: started

etc/kayobe/ansible/pulp-repo-promote-production.yml

@@ -3,7 +3,7 @@
   hosts: localhost
   gather_facts: true
   tasks:
-    - name: Ensure repository publications exist
+    - name: Ensure repository distributions exist
       ansible.builtin.import_role:
         name: stackhpc.pulp.pulp_distribution
       vars:

etc/kayobe/ansible/rabbitmq-reset.yml

@@ -31,7 +31,7 @@
       register: inspection
 
     - name: Ensure the {{ container_name }} container is running
-      ansible.builtin.command: systemctl start kolla-{{ container_name }}-container.service
+      ansible.builtin.command: systemctl start kolla-{{ container_name }}-container.service  # noqa command-instead-of-module
       when: inspection.stdout == 'false'
 
     - name: Wait for the {{ container_name }} container to reach state 'Running'
@@ -48,12 +48,16 @@
 
     - name: Stop app
       ansible.builtin.command: docker exec {{ container_name }} /bin/bash -c 'rabbitmqctl stop_app'
+
     - name: Force reset app
       ansible.builtin.command: docker exec {{ container_name }} /bin/bash -c 'rabbitmqctl force_reset'
+
     - name: Start app
       ansible.builtin.command: docker exec {{ container_name }} /bin/bash -c 'rabbitmqctl start_app'
+
     - name: Wait for all nodes to join the cluster
       ansible.builtin.command: docker exec {{ container_name }} /bin/bash -c 'rabbitmqctl await_online_nodes {{ groups['controllers'] | length }}'
+
 - name: Restart OpenStack services
   hosts: controllers:compute
   become: true

etc/kayobe/ansible/smartmon-tools.yml

@@ -1,5 +1,5 @@
 ---
-- name: Install smartmon-tools
+- name: Install and set up smartmon-tools
   hosts: overcloud
 
   tasks:

etc/kayobe/ansible/stackhpc-openstack-tests.yml

@@ -46,7 +46,7 @@
           ansible.builtin.pip:
             name:
               - "{{ repo_tmpdir.path }}"
-              - -r{{ repo_tmpdir.path }}/requirements.txt
+              - "-r {{ repo_tmpdir.path }}/requirements.txt"
               - pytest-html
               - pytest-timeout
             virtualenv: "{{ sot_venv }}"

etc/kayobe/ansible/vault-deploy-overcloud.yml

@@ -83,7 +83,7 @@
         file: "{{ kayobe_env_config_path }}/vault/overcloud-vault-keys.json"
         name: vault_keys
 
-    - name: Import vault unseal role
+    - name: Apply vault unseal role
       ansible.builtin.import_role:
         name: stackhpc.hashicorp.vault_unseal
       vars:
@@ -99,7 +99,7 @@
   gather_facts: true
   hosts: controllers[0]
   tasks:
-    - name: Import vault pki role
+    - name: Apply vault pki role
       ansible.builtin.import_role:
         name: stackhpc.hashicorp.vault_pki
       vars:

etc/kayobe/ansible/wazuh-manager.yml

@@ -34,7 +34,8 @@
           ansible.builtin.assert:
             that: local_custom_certs_path is not defined
             fail_msg: The variable, `local_custom_certs_path`, is no longer used. Please remove this variable.
-- name: Apply wazuh indexer role
+
+- name: Apply Wazuh indexer role
   hosts: localhost
   roles:
     - role: wazuh-ansible/wazuh-ansible/roles/wazuh/wazuh-indexer