Skip to content

Set check_mode to false for Kayobe/Kolla-Ansible version checks #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions etc/kayobe/ansible/check-kayobe-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
tasks:
- name: Check version
when: stackhpc_enable_kayobe_check
check_mode: false
block:
- name: Get package info
community.general.pip_package_info:
Expand All @@ -34,7 +35,7 @@
dest: /tmp/kayobe-git
version: stackhpc/{{ openstack_release }}

- name: Get tag from Kayobe commit

Check warning on line 38 in etc/kayobe/ansible/check-kayobe-version.yml

View workflow job for this annotation

GitHub Actions / Ansible 2.16 lint with Python 3.12

command-instead-of-module

git used in place of git module

Check warning on line 38 in etc/kayobe/ansible/check-kayobe-version.yml

View workflow job for this annotation

GitHub Actions / Ansible 2.15 lint with Python 3.10

command-instead-of-module

git used in place of git module
ansible.builtin.command:
cmd: git describe --tags {{ kayobe_git_commit.stdout }}
chdir: /tmp/kayobe-git
Expand Down
1 change: 1 addition & 0 deletions etc/kayobe/ansible/check-kolla-ansible-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
tasks:
- name: Check version
when: stackhpc_enable_kolla_ansible_check
check_mode: false
block:
- name: Get current Kolla-Ansible tag

Check warning on line 11 in etc/kayobe/ansible/check-kolla-ansible-version.yml

View workflow job for this annotation

GitHub Actions / Ansible 2.16 lint with Python 3.12

command-instead-of-module

git used in place of git module

Check warning on line 11 in etc/kayobe/ansible/check-kolla-ansible-version.yml

View workflow job for this annotation

GitHub Actions / Ansible 2.15 lint with Python 3.10

command-instead-of-module

git used in place of git module
ansible.builtin.command:
cmd: git describe --tags
chdir: "{{ lookup('ansible.builtin.env', 'KOLLA_SOURCE_PATH') }}"
Expand Down
Loading