Skip to content

Increase test coverage for ChatAdapter #8120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenmoneygithub opened this issue Apr 25, 2025 · 3 comments
Open

Increase test coverage for ChatAdapter #8120

chenmoneygithub opened this issue Apr 25, 2025 · 3 comments
Assignees
@JHMuir
Labels
good first issue Good for newcomers

Comments

@chenmoneygithub
Copy link
Collaborator

While we have unit tests for ChatAdapter in tests/adapters/test_chat_adapter.py, it's only covering a few cases. We should add test cases to cover:

  • Different input field and output field types, including pydantic models and nested types.
  • The request sent to LM contains the signature information as expected.
  • On failure like parsing errors, an explicit error is raised.
@chenmoneygithub chenmoneygithub added the good first issue Good for newcomers label Apr 25, 2025
@JHMuir
Copy link
Contributor

JHMuir commented Apr 26, 2025

Hey can I pick this up?

@chenmoneygithub
Copy link
Collaborator Author

@JHMuir sure thing, assigned!

@JHMuir JHMuir mentioned this issue May 4, 2025
Merged
@JHMuir
Copy link
Contributor

JHMuir commented May 4, 2025

Hello, I've pushed the requested changes and made a PR. Thanks for letting me work on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JHMuir JHMuir

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chenmoneygithub @JHMuir