Skip to content

feat: add math/base/special/csc #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 29, 2024
Merged

feat: add math/base/special/csc #1410

merged 3 commits into from
Feb 29, 2024

Conversation

MSP20086
Copy link
Contributor

@MSP20086 MSP20086 commented Feb 28, 2024 •
edited
Loading

Resolves #226

Description

What is the purpose of this pull request?

This pull request:

  • Calculates the cosecant for an input in radians
  • Also has the benchmarks, tests and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

image image image

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter
Copy link
Member

Planeshifter commented Feb 28, 2024 •
edited
Loading

Thanks for your contribution! We will try to review soon.

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

Planeshifter
Planeshifter approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good; only issue was the source files not following the spacing conventions of the project, which err towards using spaces around parentheses and the like.

Thanks for your contribution! Will merge once CI has passed.

@Planeshifter
Apply suggestions from code review
e092776 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit b60ef62 into stdlib-js:develop Feb 29, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. labels Feb 29, 2024
@kgryte kgryte changed the title feat: added @stdlib/math/base/special/csc feat: add math/base/special/csc Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: add support for computing the cosecant (csc)
4 participants
@MSP20086 @Planeshifter @stdlib-bot @kgryte