Skip to content

[RFC]: add C implementation for @stdlib/math/base/special/cabs2f #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RFC]: add C implementation for @stdlib/math/base/special/cabs2f #4442

wants to merge 1 commit into from

Conversation

DhruvArvindSingh
Copy link
Contributor

Resolves .

Description

What is the purpose of this pull request?

This pull request:

  • This PR adds C implementation for @stdlib/math/base/special/cabs2f

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Should i implement stdlib_complex64_t as the unary argument with STDLIB_MATH_BASE_NAPI_MODULE_C_F as the napi function?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@DhruvArvindSingh
refactor: add c implementation for @stdlib/math/base/special/cabs2f
a4d9c4e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 1, 2025
@DhruvArvindSingh
Copy link
Contributor Author

This is an incomplete PR

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cabs2f $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte mentioned this pull request Mar 12, 2025
Closed
1 task
@anandkaranubc
Copy link
Contributor

Completed via #4767

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 19, 2025
@anandkaranubc anandkaranubc added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DhruvArvindSingh @stdlib-bot @anandkaranubc