Skip to content

feat: add lapack/base/dgttrf #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coehemang
Copy link
Contributor

@coehemang coehemang commented May 16, 2025

Progresses #2464

Description

What is the purpose of this pull request?

This pull request:

  • Adds an implementation of the dgttrf routine, which performs LU factorization of a real tridiagonal matrix using partial pivoting and row interchanges.
  • Implements the function as per LAPACK’s DGTTRF routine, storing the factorized components (L and U) in-place in the original input arrays.
  • Prepares groundwork for corresponding solver routines such as dgttrs.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Test cases are passing with also test cases checked through fixtures
image

Example file
image

benchmark run :
image

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label May 16, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 16, 2025
@kgryte
Copy link
Member

kgryte commented May 16, 2025

@coehemang As an FYI, it looks like there is already a PR up for review for dgttrf: #5754

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dgttrf $\color{red}198/227$
$\color{green}+87.22\%$
$\color{red}39/48$
$\color{green}+81.25\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{red}198/227$
$\color{green}+87.22\%$

The above coverage report was generated for the changes in this PR.

@coehemang coehemang changed the title feat/dgttrf feat: 'add lapack/base/dgttrf' May 16, 2025
@coehemang coehemang changed the title feat: 'add lapack/base/dgttrf' feat: add lapack/base/dgttrf May 16, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

1 similar comment
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@ShabiShett07
Copy link
Contributor

Hello @coehemang, I think there is a PR #5754 for this package

@coehemang
Copy link
Contributor Author

Hello @coehemang, I think there is a PR #5754 for this package

oh i see i should close this than

@coehemang coehemang closed this May 16, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants