Skip to content

Commit 2ed7a7f

Browse files
committed
[SYCL] Fix unused variable warnings and unittests
This commit fixes unusued variable warnings after intel#7468. Additionally it replaces asserts in the unittests with EXPECT_EQ. Signed-off-by: Larsen, Steffen <[email protected]>
1 parent 992ef06 commit 2ed7a7f

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

sycl/include/sycl/ext/intel/experimental/pipes.hpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ class pipe : public pipe_base {
6868
// Host API
6969
static _dataT read(queue &Q, bool &Success,
7070
memory_order Order = memory_order::seq_cst) {
71+
// Order is currently unused.
72+
std::ignore = Order;
73+
7174
const device Dev = Q.get_device();
7275
bool IsPipeSupported =
7376
Dev.has_extension("cl_intel_program_scope_host_pipe");
@@ -95,6 +98,9 @@ class pipe : public pipe_base {
9598

9699
static void write(queue &Q, const _dataT &Data, bool &Success,
97100
memory_order Order = memory_order::seq_cst) {
101+
// Order is currently unused.
102+
std::ignore = Order;
103+
98104
const device Dev = Q.get_device();
99105
bool IsPipeSupported =
100106
Dev.has_extension("cl_intel_program_scope_host_pipe");
@@ -221,6 +227,9 @@ class pipe : public pipe_base {
221227

222228
// Host API
223229
static _dataT read(queue &Q, memory_order Order = memory_order::seq_cst) {
230+
// Order is currently unused.
231+
std::ignore = Order;
232+
224233
const device Dev = Q.get_device();
225234
bool IsPipeSupported =
226235
Dev.has_extension("cl_intel_program_scope_host_pipe");
@@ -241,6 +250,9 @@ class pipe : public pipe_base {
241250

242251
static void write(queue &Q, const _dataT &Data,
243252
memory_order Order = memory_order::seq_cst) {
253+
// Order is currently unused.
254+
std::ignore = Order;
255+
244256
const device Dev = Q.get_device();
245257
bool IsPipeSupported =
246258
Dev.has_extension("cl_intel_program_scope_host_pipe");

sycl/unittests/pipes/host_pipe_registration.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ pi_result after_piDeviceGetInfo(pi_device device, pi_device_info param_name,
100100
switch (param_name) {
101101
case PI_DEVICE_INFO_EXTENSIONS: {
102102
if (param_value) {
103+
std::ignore = param_value_size;
103104
assert(param_value_size >= sizeof(MockSupportedExtensions));
104105
std::memcpy(param_value, MockSupportedExtensions,
105106
sizeof(MockSupportedExtensions));
@@ -153,10 +154,10 @@ TEST_F(PipeTest, Basic) {
153154
// Testing read
154155
int HostPipeReadData;
155156
HostPipeReadData = Pipe::read(q);
156-
assert(HostPipeReadData == PipeReadVal);
157+
EXPECT_EQ(HostPipeReadData, PipeReadVal);
157158

158159
// Testing write
159160
int HostPipeWriteData = 9;
160161
Pipe::write(q, HostPipeWriteData);
161-
assert(PipeWriteVal == 9);
162+
EXPECT_EQ(PipeWriteVal, 9);
162163
}

0 commit comments

Comments
 (0)