Revert "Fix Image Update Test Cleanup"

awgreene · stevekuznetsov · commit 2efa92831ed0 · 2023-11-09T10:21:36.000-07:00
This reverts commit 2abfb3c18528b23f531db0b4baf64ab641f38036.

Signed-off-by: Alexander Greene &lt;greene.al1991@gmail.com&gt;
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e8afbf7e5abe049f54fe5d9569e72863be9879f4
diff --git a/staging/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go b/staging/operator-lifecycle-manager/test/e2e/catalog_e2e_test.go
@@ -943,7 +943,7 @@ var _ = Describe("Starting CatalogSource e2e tests", func() {
 				APIGroup: "rbac.authorization.k8s.io",
 			},
 		}
-		roleBinding, err = c.CreateRoleBinding(roleBinding)
+		_, err = c.CreateRoleBinding(roleBinding)
 		Expect(err).ToNot(HaveOccurred(), "error granting registry-viewer permissions")
 		defer func() {
 			err := c.DeleteRoleBinding(roleBinding.GetNamespace(), roleBinding.GetName(), &metav1.DeleteOptions{})

Original file line number	Diff line number	Diff line change
`@@ -943,7 +943,7 @@ var _ = Describe("Starting CatalogSource e2e tests", func() {`
`943`	`943`	`APIGroup: "rbac.authorization.k8s.io",`
`944`	`944`	`},`
`945`	`945`	`}`
`946`		`- roleBinding, err = c.CreateRoleBinding(roleBinding)`
	`946`	`+ _, err = c.CreateRoleBinding(roleBinding)`
`947`	`947`	`Expect(err).ToNot(HaveOccurred(), "error granting registry-viewer permissions")`
`948`	`948`	`defer func() {`
`949`	`949`	`err := c.DeleteRoleBinding(roleBinding.GetNamespace(), roleBinding.GetName(), &metav1.DeleteOptions{})`