Fix PHP 7.4 regression, changed behavior of get_declared_classes()

Since PHP 7.4 get_declared_classes() does not guarantee any order. That
implies that parent classes aren't the first any more, rendering the
array_reverse() technique futile for the loop & break code that follows.
So, additionally, let's try to reduce the list of candidates by removing all
the classes known to be "parents". That way, at the end, only the "main"
class just included with remain.

Upstream PR:
  squizlabs/PHP_CodeSniffer#3130

Source:
  https://raw.githubusercontent.com/php/php-src/PHP-7.4/UPGRADING

Text:
  Previously get_declared_classes() always returned parent classes before
  child classes. This is no longer the case. No particular order is guaranteed
  for the get_declared_classes() return value.

Author: stronk7

phpcs/autoload.php

@@ -168,6 +168,22 @@ public static function loadFile($path)
 
             $className  = null;
             $newClasses = array_reverse(array_diff(get_declared_classes(), $classes));
+            // Since PHP 7.4 get_declared_classes() does not guarantee any order. That
+            // implies that parent classes aren't the first any more, rendering the
+            // array_reverse() technique futile for the loop & break code that follows.
+            // So, additionally, let's try to reduce the list of candidates by removing all
+            // the classes known to be "parents". That way, at the end, only the "main"
+            // class just included with remain.
+            $newClasses = array_reduce(
+                $newClasses,
+                function ($remaining, $current) {
+                    return array_diff($remaining, class_parents($current));
+                },
+                $newClasses
+            );
+            $newClasses = array_reduce($newClasses, function($remaining, $current) {
+                return array_diff($remaining, class_parents($current));
+            }, $newClasses);
             foreach ($newClasses as $name) {
                 if (isset(self::$loadedFiles[$name]) === false) {
                     $className = $name;

readme_moodle.txt

@@ -15,7 +15,7 @@ Current checkout:
 
 Local modifications (only allowed if there is a PR upstream backing it):
 
-  - none right now
+  - PHP 7.4 fix: https://github.com/squizlabs/PHP_CodeSniffer/pull/3130
 
 ===== ===== ===== ===== ===== ===== =====