Skip to content

Commit 88653d1

Browse files
authored
Merge pull request #160 from zevaverbach/fix/small-test-optimization
avoid building skipped tests vector in every loop
2 parents e0df165 + 265267b commit 88653d1

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

crates/pg_syntax/tests/pg_syntax_tests.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ const SNAPSHOTS_PATH: &str = "snapshots/data";
1515
#[test]
1616
fn valid_statements() {
1717
// dont do postgres regress tests for now
18+
let skipped_tests: Vec<_> = SKIPPED_REGRESS_TESTS.lines().collect();
19+
1820
for path in [VALID_STATEMENTS_PATH] {
1921
let mut paths: Vec<_> = fs::read_dir(path).unwrap().map(|r| r.unwrap()).collect();
2022
paths.sort_by_key(|dir| dir.path());
@@ -23,11 +25,7 @@ fn valid_statements() {
2325
let path = f.path();
2426
let test_name = path.file_stem().unwrap().to_str().unwrap();
2527

26-
if SKIPPED_REGRESS_TESTS
27-
.lines()
28-
.collect::<Vec<_>>()
29-
.contains(&test_name)
30-
{
28+
if skipped_tests.contains(&test_name) {
3129
continue;
3230
}
3331

0 commit comments

Comments
 (0)