refactor: Remove unnecessary comments

Author: KShivendu

supertokens_python/recipe/session/interfaces.py

@@ -86,10 +86,9 @@ def __init__(
 class ReqResInfo:
     def __init__(
         self,
-        request: Optional[BaseRequest] = None,
-        transfer_method: Optional[TokenTransferMethod] = None,
+        request: BaseRequest,
+        transfer_method: TokenTransferMethod,
     ):
-        # TODO: See if making args optional will cause any issues
         self.request = request
         self.transfer_method = transfer_method
 

tests/frontendIntegration/fastapi-server/app.py

@@ -144,7 +144,7 @@ def get_app_port():
 
 
 def config(
-    enable_anti_csrf: bool, enable_jwt: bool, jwt_property_name: Union[str, None]
+    enable_anti_csrf: bool, enable_jwt: bool, _jwt_property_name: Union[str, None]
 ):
     anti_csrf: Literal["VIA_TOKEN", "NONE"] = "NONE"
     if enable_anti_csrf:

tests/frontendIntegration/flask-server/app.py

@@ -166,7 +166,7 @@ def get_app_port():
 
 
 def config(
-    enable_anti_csrf: bool, enable_jwt: bool, jwt_property_name: Union[str, None]
+    enable_anti_csrf: bool, enable_jwt: bool, _jwt_property_name: Union[str, None]
 ):
     anti_csrf: Literal["VIA_TOKEN", "NONE"] = "NONE"
     if enable_anti_csrf:

tests/sessions/claims/test_assert_claims.py

@@ -10,7 +10,6 @@
 from supertokens_python.recipe.session.claims import PrimitiveClaim
 from supertokens_python.recipe.session.interfaces import (
     JSONObject,
-    ReqResInfo,
     SessionClaimValidator,
     ClaimValidationResult,
     SessionClaim,
@@ -50,7 +49,7 @@ async def test_should_not_throw_for_empty_array():
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,
         False,  # access_token_updated
     )
     with patch.object(
@@ -87,7 +86,7 @@ async def test_should_call_validate_with_the_same_payload_object():
         "test_session_handle",
         "test_user_id",
         payload,  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,  # req_res_info
         False,  # access_token_updated
     )
 

tests/sessions/claims/test_fetch_and_set_claim.py

@@ -2,7 +2,6 @@
 
 from pytest import mark
 
-from supertokens_python.recipe.session.interfaces import ReqResInfo
 from supertokens_python.recipe.session.session_class import Session
 from tests.sessions.claims.utils import NoneClaim, TrueClaim
 from tests.utils import AsyncMock, MagicMock
@@ -30,7 +29,7 @@ async def test_should_not_change_if_claim_fetch_value_returns_none():
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,
         False,  # access_token_updated
     )
 
@@ -61,7 +60,7 @@ async def test_should_update_if_claim_fetch_value_returns_value(timestamp: int):
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,  # req_res_info
         False,  # access_token_updated
     )
     with patch.object(

tests/sessions/claims/test_remove_claim.py

@@ -10,7 +10,6 @@
     get_session_information,
     remove_claim,
 )
-from supertokens_python.recipe.session.interfaces import ReqResInfo
 from supertokens_python.recipe.session.session_class import Session
 from tests.sessions.claims.utils import TrueClaim, get_st_init_args
 from tests.utils import AsyncMock, setup_function, start_st, teardown_function
@@ -39,7 +38,7 @@ async def test_should_attempt_to_set_claim_to_none():
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,  # req_res_info
         False,  # access_token_updated
     )
     with patch.object(
@@ -78,9 +77,7 @@ async def test_should_clear_previously_set_claim_using_handle(timestamp: int):
 
     session_info = await get_session_information(s.get_handle())
     assert session_info is not None
-    payload_after = (
-        session_info.access_token_payload
-    )  # FIXME: This doesn't have stuff other than userData?
+    payload_after = session_info.access_token_payload
     assert payload_after == {}
 
 

tests/sessions/claims/test_set_claim_value.py

@@ -9,7 +9,6 @@
     get_session_information,
     set_claim_value,
 )
-from supertokens_python.recipe.session.interfaces import ReqResInfo
 from supertokens_python.recipe.session.session_class import Session
 from tests.sessions.claims.utils import TrueClaim, get_st_init_args
 from tests.utils import AsyncMock, setup_function, start_st, teardown_function
@@ -40,7 +39,7 @@ async def test_should_merge_the_right_value(timestamp: int):
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,  # req_res_info
         False,  # access_token_updated
     )
     with patch.object(
@@ -88,7 +87,6 @@ async def test_should_overwrite_claim_value_using_session_handle(timestamp: int)
     s = await get_session_information(s.get_handle())
     assert s is not None
     payload = s.access_token_payload
-    # FIXME: Shouldn't this have other protected_keys as well??
     assert payload == {"st-true": {"t": timestamp, "v": False}}
 
 

tests/sessions/claims/test_verify_session.py

@@ -22,7 +22,6 @@
     ClaimValidationResult,
     SessionContainer,
     ClaimsValidationResult,
-    ReqResInfo,
 )
 from supertokens_python.recipe.session.session_class import Session
 from tests.sessions.claims.utils import TrueClaim, NoneClaim
@@ -369,7 +368,7 @@ async def test_should_reject_if_assert_claims_returns_an_error(
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,  # req_res_info
         False,  # access_token_updated
     )
     with patch.object(Session, "assert_claims", wraps=s.assert_claims) as mock:
@@ -417,7 +416,7 @@ async def test_should_allow_if_assert_claims_returns_no_error(
         "test_session_handle",
         "test_user_id",
         {},  # user_data_in_access_token
-        ReqResInfo(None, None),
+        None,  # req_res_info
         False,  # access_token_updated
     )