Skip to content

Commit 986e912

Browse files
committed
fix: Upgrade pyjwt in requirements and improve comments
1 parent 083a6dd commit 986e912

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ pycodestyle==2.8.0
4949
pycparser==2.21
5050
pycryptodome==3.10.4
5151
pydantic==1.9.0
52-
PyJWT==2.0.1
52+
PyJWT==2.6.0
5353
pylint==2.12.2
5454
pyparsing==3.0.7
5555
pyright==1.1.236

supertokens_python/recipe/session/session_request_functions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@
6060
is_an_ip_address,
6161
)
6262

63-
# In all cases: if sIdRefreshToken token exists (so it's a legacy session) we clear it.
64-
# Check http://localhost:3002/docs/contribute/decisions/session/0008 for further details and a table of expected behaviours
6563
LEGACY_ID_REFRESH_TOKEN_COOKIE_NAME = "sIdRefreshToken"
6664

6765

@@ -303,6 +301,10 @@ async def create_new_session_in_request(
303301
return result.session
304302

305303

304+
# In all cases: if sIdRefreshToken token exists (so it's a legacy session) we clear it.
305+
# Check http://localhost:3002/docs/contribute/decisions/session/0008 for further details and a table of expected behaviours
306+
307+
306308
async def refresh_session_in_request(
307309
request: Any,
308310
user_context: Dict[str, Any],

tests/sessions/test_auth_mode.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ async def test_should_update_acccess_token_payload(
370370
assert update_info["refreshTokenFromHeader"] is None
371371

372372
# Updated access token
373-
assert update_info["accessToken"] is not None # FIXME: this is failing
373+
assert update_info["accessToken"] is not None
374374
assert update_info["accessToken"] != res["accessTokenFromHeader"]
375375
# Updated front token
376376
assert update_info["frontToken"] is not None

0 commit comments

Comments
 (0)