Skip to content

Commit a0b8529

Browse files
committed
fix: Add tenant_id to claim build func
1 parent 93500de commit a0b8529

File tree

7 files changed

+16
-13
lines changed

7 files changed

+16
-13
lines changed

supertokens_python/recipe/session/asyncio/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ async def create_new_session_without_request_response(
102102
final_access_token_payload = {**access_token_payload, "iss": issuer}
103103

104104
for claim in claims_added_by_other_recipes:
105-
update = await claim.build(user_id, user_context)
105+
# TODO: Pass tenant id
106+
update = await claim.build(user_id, "pass-tenant-id", user_context)
106107
final_access_token_payload = {**final_access_token_payload, **update}
107108

108109
return await SessionRecipe.get_instance().recipe_implementation.create_new_session(

supertokens_python/recipe/session/interfaces.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -628,13 +628,12 @@ def get_value_from_payload(
628628
"""Gets the value of the claim stored in the payload"""
629629

630630
async def build(
631-
self, user_id: str, user_context: Optional[Dict[str, Any]] = None
631+
self, user_id: str, tenant_id: str, user_context: Optional[Dict[str, Any]] = None
632632
) -> JSONObject:
633633
if user_context is None:
634634
user_context = {}
635635

636-
# TODO: change this to tenant_id
637-
value = await resolve(self.fetch_value(user_id, "pass-tenant-id", user_context))
636+
value = await resolve(self.fetch_value(user_id, tenant_id, user_context))
638637

639638
if value is None:
640639
return {}

supertokens_python/recipe/session/recipe_implementation.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,8 +383,9 @@ async def fetch_and_set_claim(
383383
if session_info is None:
384384
return False
385385

386+
# TODO: Pass tenant id
386387
access_token_payload_update = await claim.build(
387-
session_info.user_id, user_context
388+
session_info.user_id, "pass-tenant-id", user_context
388389
)
389390
return await self.merge_into_access_token_payload(
390391
session_handle, access_token_payload_update, user_context

supertokens_python/recipe/session/session_class.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,8 @@ async def fetch_and_set_claim(
220220
if user_context is None:
221221
user_context = {}
222222

223-
update = await claim.build(self.get_user_id(), user_context)
223+
# TODO: Pass tenant id
224+
update = await claim.build(self.get_user_id(), "pass-tenant-id", user_context)
224225
return await self.merge_into_access_token_payload(update, user_context)
225226

226227
async def set_claim_value(

supertokens_python/recipe/session/session_request_functions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,8 @@ async def create_new_session_in_request(
238238
final_access_token_payload = {**access_token_payload, "iss": issuer}
239239

240240
for claim in claims_added_by_other_recipes:
241-
update = await claim.build(user_id, user_context)
241+
# TODO: Pass tenant id
242+
update = await claim.build(user_id, "pass-tenant-id", user_context)
242243
final_access_token_payload = {**final_access_token_payload, **update}
243244

244245
log_debug_message("createNewSession: Access token payload built")

tests/sessions/claims/test_primitive_array_claim.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,21 +57,21 @@ def patch_get_timestamp_ms(pac_time_patch: Tuple[MockerFixture, int]):
5757
async def test_primitive_claim(timestamp: int):
5858
claim = PrimitiveArrayClaim("key", sync_fetch_value)
5959
ctx = {}
60-
res = await claim.build("user_id", ctx)
60+
res = await claim.build("user_id", "public", ctx)
6161
assert res == {"key": {"t": timestamp, "v": val}}
6262

6363

6464
async def test_primitive_claim_without_async_fetch_value(timestamp: int):
6565
claim = PrimitiveArrayClaim("key", async_fetch_value)
6666
ctx = {}
67-
res = await claim.build("user_id", ctx)
67+
res = await claim.build("user_id", "public", ctx)
6868
assert res == {"key": {"t": timestamp, "v": val}}
6969

7070

7171
async def test_primitive_claim_matching__add_to_payload():
7272
claim = PrimitiveArrayClaim("key", sync_fetch_value)
7373
ctx = {}
74-
res = await claim.build("user_id", ctx)
74+
res = await claim.build("user_id", "public", ctx)
7575
assert res == claim.add_to_payload_({}, val, {})
7676

7777

tests/sessions/claims/test_primitive_claim.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,21 @@ def teardown_function(_):
2323
async def test_primitive_claim(timestamp: int):
2424
claim = PrimitiveClaim("key", sync_fetch_value)
2525
ctx = {}
26-
res = await claim.build("user_id", ctx)
26+
res = await claim.build("user_id", "public", ctx)
2727
assert res == {"key": {"t": timestamp, "v": val}}
2828

2929

3030
async def test_primitive_claim_without_async_fetch_value(timestamp: int):
3131
claim = PrimitiveClaim("key", async_fetch_value)
3232
ctx = {}
33-
res = await claim.build("user_id", ctx)
33+
res = await claim.build("user_id", "public", ctx)
3434
assert res == {"key": {"t": timestamp, "v": val}}
3535

3636

3737
async def test_primitive_claim_matching__add_to_payload():
3838
claim = PrimitiveClaim("key", sync_fetch_value)
3939
ctx = {}
40-
res = await claim.build("user_id", ctx)
40+
res = await claim.build("user_id", "public", ctx)
4141
assert res == claim.add_to_payload_({}, val, {})
4242

4343

0 commit comments

Comments
 (0)