Skip to content

Commit e5354d9

Browse files
committed
Improve passing of third party id in ProviderConfigForClient
1 parent 1dca00f commit e5354d9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

supertokens_python/recipe/thirdparty/provider.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ def __init__(
226226
force_pkce: bool = False,
227227
additional_config: Optional[Dict[str, Any]] = None,
228228
# CommonProviderConfig:
229-
third_party_id: Optional[str] = None,
229+
third_party_id: str = "temp",
230230
name: Optional[str] = None,
231231
authorization_endpoint: Optional[str] = None,
232232
authorization_endpoint_query_params: Optional[
@@ -262,7 +262,7 @@ def __init__(
262262
)
263263
CommonProviderConfig.__init__(
264264
self,
265-
third_party_id or "", # FIXME?
265+
third_party_id,
266266
name,
267267
authorization_endpoint,
268268
authorization_endpoint_query_params,

supertokens_python/recipe/thirdparty/providers/custom.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,8 @@ def __init__(self, provider_config: ProviderConfig):
180180
self.input_config = input_config = self._normalize_input(provider_config)
181181

182182
provider_config_for_client = ProviderConfigForClient(
183-
# Will automatically get replaced by correct value
183+
# Will automatically get replaced with correct value
184+
# in get_provider_config_for_client
184185
# when fetch_and_set_config function runs
185186
client_id="temp",
186187
client_secret=None,

0 commit comments

Comments
 (0)