Skip to content

Commit e58cb87

Browse files
committed
feat: Changes suggested in feedback
1 parent 3663a1d commit e58cb87

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

supertokens_python/recipe/session/interfaces.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -602,12 +602,9 @@ class SessionClaimValidator(ABC):
602602
def __init__(
603603
self,
604604
id_: str,
605-
claim: Optional[
606-
SessionClaim[_T] # pyright: ignore[reportInvalidTypeVarUse]
607-
] = None,
608605
) -> None:
609606
self.id = id_
610-
self.claim = claim
607+
self.claim: Optional[SessionClaim[Any]] = None
611608

612609
@abstractmethod
613610
async def validate(

supertokens_python/recipe/session/recipe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ class SessionRecipe(RecipeModule):
6666
recipe_id = "session"
6767
__instance = None
6868

69-
claims_added_by_other_recipes: List[SessionClaim[Any]] = []
70-
claim_validators_added_by_other_recipes: List[SessionClaimValidator] = []
71-
7269
def __init__(
7370
self,
7471
recipe_id: str,
@@ -156,6 +153,9 @@ def __init__(
156153
else self.config.override.apis(api_implementation)
157154
)
158155

156+
self.claims_added_by_other_recipes: List[SessionClaim[Any]] = []
157+
self.claim_validators_added_by_other_recipes: List[SessionClaimValidator] = []
158+
159159
def is_error_from_this_recipe_based_on_instance(self, err: Exception) -> bool:
160160
return isinstance(err, SuperTokensError) and (
161161
isinstance(err, SuperTokensSessionError)

tests/sessions/claims/test_assert_claims.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ async def test_should_call_validate_with_the_same_payload_object():
4949

5050
class DummyClaimValidator(SessionClaimValidator):
5151
def __init__(self, claim: SessionClaim[Any]):
52-
super().__init__("claim_validator_id", claim)
52+
super().__init__("claim_validator_id")
53+
self.claim = claim
5354
self.validate_calls: Dict[str, int] = {}
5455

5556
async def validate(

tests/sessions/claims/test_verify_session.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ async def new_get_global_claim_validators(
8787

8888
class AlwaysValidValidator(SessionClaimValidator):
8989
def __init__(self):
90-
super().__init__("always-valid-validator", TrueClaim)
90+
super().__init__("always-valid-validator")
91+
self.claim = TrueClaim
9192

9293
async def validate(
9394
self, payload: JSONObject, user_context: Union[Dict[str, Any], None] = None
@@ -100,7 +101,8 @@ def should_refetch(self, payload: JSONObject, user_context: Dict[str, Any]):
100101

101102
class AlwaysInvalidValidator(SessionClaimValidator):
102103
def __init__(self, reason: Optional[Dict[str, Any]]):
103-
super().__init__("always-invalid-validator", TrueClaim)
104+
super().__init__("always-invalid-validator")
105+
self.claim = TrueClaim
104106
self.reason = reason
105107

106108
async def validate(
@@ -169,7 +171,8 @@ async def refetched_claim2( # type: ignore
169171

170172
class CustomValidator(SessionClaimValidator):
171173
def __init__(self, is_valid: bool):
172-
super().__init__("test_id", TrueClaim)
174+
super().__init__("test_id")
175+
self.claim = TrueClaim
173176
self.is_valid = is_valid
174177

175178
async def validate(

0 commit comments

Comments
 (0)