chore: improve signal runtime perf (#12093)

trueadm · web-flow · commit 04eaf1751902 · 2024-06-19T20:54:28.000+01:00
* chore: improve signal runtime perf

* chore: improve signal runtime perf

* chore: improve signal runtime perf
diff --git a/.changeset/sweet-bottles-check.md b/.changeset/sweet-bottles-check.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+chore: improve runtime performance of capturing reactive signals
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -357,11 +357,7 @@ export function execute_reaction_fn(signal) {
 
 					if (reactions === null) {
 						dependency.reactions = [signal];
-					} else if (reactions[reactions.length - 1] !== signal) {
-						// TODO: should this be:
-						//
-						// } else if (!reactions.includes(signal)) {
-						//
+					} else if (reactions[reactions.length - 1] !== signal && !reactions.includes(signal)) {
 						reactions.push(signal);
 					}
 				}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"svelte": patch
 +---
++
 +chore: improve runtime performance of capturing reactive signals
Original file line number	Diff line number	Diff line change
`@@ -357,11 +357,7 @@ export function execute_reaction_fn(signal) {`
`357`	`357`
`358`	`358`	`if (reactions === null) {`
`359`	`359`	`dependency.reactions = [signal];`
`360`		`- } else if (reactions[reactions.length - 1] !== signal) {`
`361`		`- // TODO: should this be:`
`362`		`- //`
`363`		`- // } else if (!reactions.includes(signal)) {`
`364`		`- //`
	`360`	`+ } else if (reactions[reactions.length - 1] !== signal && !reactions.includes(signal)) {`
`365`	`361`	`reactions.push(signal);`
`366`	`362`	`}`
`367`	`363`	`}`