fix

Author: Rich-Harris

packages/svelte/src/compiler/phases/2-analyze/index.js

@@ -7,7 +7,7 @@ import * as e from '../../errors.js';
 import * as w from '../../warnings.js';
 import { is_text_attribute } from '../../utils/ast.js';
 import * as b from '../../utils/builders.js';
-import { ReservedKeywords, Runes } from '../constants.js';
+import { Runes } from '../constants.js';
 import { Scope, ScopeRoot, create_scopes, get_rune } from '../scope.js';
 import check_graph_for_cycles from './utils/check_graph_for_cycles.js';
 import { create_attribute } from '../nodes.js';
@@ -203,6 +203,8 @@ function get_component_name(filename) {
 	return name[0].toUpperCase() + name.slice(1);
 }
 
+const RESERVED = ['$$props', '$$restProps', '$$slots'];
+
 /**
  * @param {Program} ast
  * @param {ValidatedModuleCompileOptions} options
@@ -212,7 +214,7 @@ export function analyze_module(ast, options) {
 	const { scope, scopes } = create_scopes(ast, new ScopeRoot(), false, null);
 
 	for (const [name, references] of scope.references) {
-		if (name[0] !== '$' || ReservedKeywords.includes(name)) continue;
+		if (name[0] !== '$' || RESERVED.includes(name)) continue;
 		if (name === '$' || name[1] === '$') {
 			e.global_reference_invalid(references[0].node, name);
 		}
@@ -257,7 +259,7 @@ export function analyze_component(root, source, options) {
 
 	// create synthetic bindings for store subscriptions
 	for (const [name, references] of module.scope.references) {
-		if (name[0] !== '$' || ReservedKeywords.includes(name)) continue;
+		if (name[0] !== '$' || RESERVED.includes(name)) continue;
 		if (name === '$' || name[1] === '$') {
 			e.global_reference_invalid(references[0].node, name);
 		}

packages/svelte/src/compiler/phases/2-analyze/visitors/BindDirective.js

@@ -9,7 +9,7 @@ import { validate_no_const_assignment } from './shared/utils.js';
 import * as e from '../../../errors.js';
 import * as w from '../../../warnings.js';
 import { binding_properties } from '../../bindings.js';
-import { ContentEditableBindings, SVGElements } from '../../constants.js';
+import { CONTENT_EDITABLE_BINDINGS, SVGElements } from '../../constants.js';
 import fuzzymatch from '../../1-parse/utils/fuzzymatch.js';
 
 /**
@@ -205,7 +205,7 @@ export function BindDirective(node, context) {
 				);
 			}
 
-			if (ContentEditableBindings.includes(node.name)) {
+			if (CONTENT_EDITABLE_BINDINGS.includes(node.name)) {
 				const contenteditable = /** @type {Attribute} */ (
 					parent.attributes.find((a) => a.type === 'Attribute' && a.name === 'contenteditable')
 				);

packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js

@@ -14,7 +14,7 @@ import {
 import * as w from '../../../../warnings.js';
 import fuzzymatch from '../../../1-parse/utils/fuzzymatch.js';
 import { is_event_attribute, is_text_attribute } from '../../../../utils/ast.js';
-import { ContentEditableBindings } from '../../../constants.js';
+import { CONTENT_EDITABLE_BINDINGS } from '../../../constants.js';
 import { walk } from 'zimmerframe';
 import { list } from '../../../../utils/string.js';
 
@@ -722,7 +722,7 @@ export function check_element(node, state) {
 			}
 		} else if (
 			attribute.type === 'BindDirective' &&
-			ContentEditableBindings.includes(attribute.name)
+			CONTENT_EDITABLE_BINDINGS.includes(attribute.name)
 		) {
 			has_contenteditable_binding = true;
 		}

packages/svelte/src/compiler/phases/3-transform/server/visitors/shared/element.js

@@ -7,11 +7,7 @@ import {
 	is_text_attribute
 } from '../../../../../utils/ast.js';
 import { binding_properties } from '../../../../bindings.js';
-import {
-	ContentEditableBindings,
-	LoadErrorElements,
-	WhitespaceInsensitiveAttributes
-} from '../../../../constants.js';
+import { CONTENT_EDITABLE_BINDINGS, LoadErrorElements } from '../../../../constants.js';
 import {
 	create_attribute,
 	create_expression_metadata,
@@ -26,6 +22,8 @@ import {
 import { serialize_attribute_value } from './utils.js';
 import { is_boolean_attribute } from '../../../../../../utils.js';
 
+const WHITESPACE_INSENSITIVE_ATTRIBUTES = ['class', 'style'];
+
 /**
  * Writes the output to the template output. Some elements may have attributes on them that require the
  * their output to be the child content instead. In this case, an object is returned.
@@ -108,7 +106,7 @@ export function serialize_element_attributes(node, context) {
 			const binding = binding_properties[attribute.name];
 			if (binding?.omit_in_ssr) continue;
 
-			if (ContentEditableBindings.includes(attribute.name)) {
+			if (CONTENT_EDITABLE_BINDINGS.includes(attribute.name)) {
 				content = /** @type {Expression} */ (context.visit(attribute.expression));
 			} else if (attribute.name === 'value' && node.name === 'textarea') {
 				content = b.call(
@@ -227,7 +225,7 @@ export function serialize_element_attributes(node, context) {
 					serialize_attribute_value(
 						attribute.value,
 						context,
-						WhitespaceInsensitiveAttributes.includes(name)
+						WHITESPACE_INSENSITIVE_ATTRIBUTES.includes(name)
 					)
 				).value;
 				if (name !== 'class' || literal_value) {
@@ -248,7 +246,7 @@ export function serialize_element_attributes(node, context) {
 			const value = serialize_attribute_value(
 				attribute.value,
 				context,
-				WhitespaceInsensitiveAttributes.includes(name)
+				WHITESPACE_INSENSITIVE_ATTRIBUTES.includes(name)
 			);
 
 			context.state.template.push(
@@ -343,7 +341,7 @@ function serialize_element_spread_attributes(
 				const value = serialize_attribute_value(
 					attribute.value,
 					context,
-					WhitespaceInsensitiveAttributes.includes(name)
+					WHITESPACE_INSENSITIVE_ATTRIBUTES.includes(name)
 				);
 				return b.prop('init', b.key(name), value);
 			}

packages/svelte/src/compiler/phases/constants.js

@@ -22,14 +22,9 @@ export const Runes = /** @type {const} */ ([
  * list is almost certainly very incomplete)
  * TODO this is currently unused
  */
-export const ElementsWithoutText = ['audio', 'datalist', 'dl', 'optgroup', 'select', 'video'];
+export const ELEMENTS_WITHOUT_TEXT = ['audio', 'datalist', 'dl', 'optgroup', 'select', 'video'];
 
-export const ReservedKeywords = ['$$props', '$$restProps', '$$slots'];
-
-/** Attributes where whitespace can be compacted */
-export const WhitespaceInsensitiveAttributes = ['class', 'style'];
-
-export const ContentEditableBindings = ['textContent', 'innerHTML', 'innerText'];
+export const CONTENT_EDITABLE_BINDINGS = ['textContent', 'innerHTML', 'innerText'];
 
 export const LoadErrorElements = [
 	'body',

packages/svelte/src/constants.js

@@ -34,21 +34,6 @@ export const UNINITIALIZED = Symbol();
 export const FILENAME = Symbol('filename');
 export const HMR = Symbol('hmr');
 
-/**
- * @type {Record<string, string>}
- * List of attribute names that should be aliased to their property names
- * because they behave differently between setting them as an attribute and
- * setting them as a property.
- */
-export const ATTRIBUTE_ALIASES = {
-	// no `class: 'className'` because we handle that separately
-	formnovalidate: 'formNoValidate',
-	ismap: 'isMap',
-	nomodule: 'noModule',
-	playsinline: 'playsInline',
-	readonly: 'readOnly'
-};
-
 export const NAMESPACE_SVG = 'http://www.w3.org/2000/svg';
 export const NAMESPACE_MATHML = 'http://www.w3.org/1998/Math/MathML';