Skip to content

Commit 2c410bb

Browse files
committed
more
1 parent 54ac9cd commit 2c410bb

File tree

3 files changed

+8
-30
lines changed
  • packages/svelte/tests/runtime-runes/samples

3 files changed

+8
-30
lines changed

packages/svelte/tests/runtime-runes/samples/event-handler-component-invalid-warning/_config.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,16 @@ export default test({
77
dev: true
88
},
99

10-
test({ assert, target, warnings }) {
11-
/** @type {any} */
12-
let error;
13-
10+
test({ assert, target, warnings, errors }) {
1411
const handler = (/** @type {any}} */ e) => {
15-
error = e.error;
1612
e.stopImmediatePropagation();
1713
};
1814

1915
window.addEventListener('error', handler, true);
2016

2117
target.querySelector('button')?.click();
2218

23-
assert.throws(() => {
24-
throw error;
25-
}, /state_unsafe_mutation/);
19+
assert.include(errors[0], 'state_unsafe_mutation');
2620

2721
window.removeEventListener('error', handler, true);
2822

packages/svelte/tests/runtime-runes/samples/event-handler-invalid-values/_config.js

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { assertType } from 'vitest';
21
import { test } from '../../test';
32

43
export default test({
@@ -8,12 +7,8 @@ export default test({
87
dev: true
98
},
109

11-
test({ assert, target, warnings, logs }) {
12-
/** @type {any} */
13-
let error = null;
14-
10+
test({ assert, target, warnings, logs, errors }) {
1511
const handler = (/** @type {any} */ e) => {
16-
error = e.error;
1712
e.stopImmediatePropagation();
1813
};
1914

@@ -23,25 +18,20 @@ export default test({
2318

2419
b1.click();
2520
assert.deepEqual(logs, []);
26-
assert.equal(error, null);
27-
28-
error = null;
29-
logs.length = 0;
21+
assert.deepEqual(errors, []);
3022

3123
b2.click();
3224
assert.deepEqual(logs, ['clicked']);
33-
assert.equal(error, null);
25+
assert.deepEqual(errors, []);
3426

35-
error = null;
3627
logs.length = 0;
3728

3829
b3.click();
3930
assert.deepEqual(logs, []);
4031
assert.deepEqual(warnings, [
4132
'`click` handler at main.svelte:10:17 should be a function. Did you mean to add a leading `() =>`?'
4233
]);
43-
assert.isNotNull(error);
44-
assert.match(error.message, /is not a function/);
34+
assert.include(errors[0], 'is not a function');
4535

4636
window.removeEventListener('error', handler, true);
4737
}

packages/svelte/tests/runtime-runes/samples/event-handler-invalid-warning/_config.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,16 @@ export default test({
77
dev: true
88
},
99

10-
test({ assert, target, warnings }) {
11-
/** @type {any} */
12-
let error;
13-
10+
test({ assert, target, warnings, errors }) {
1411
const handler = (/** @type {any} */ e) => {
15-
error = e.error;
1612
e.stopImmediatePropagation();
1713
};
1814

1915
window.addEventListener('error', handler, true);
2016

2117
target.querySelector('button')?.click();
2218

23-
assert.throws(() => {
24-
throw error;
25-
}, /state_unsafe_mutation/);
19+
assert.include(errors[0], 'state_unsafe_mutation');
2620

2721
window.removeEventListener('error', handler, true);
2822

0 commit comments

Comments
 (0)