Skip to content

Commit 3085d5d

Browse files
committed
this code doesn't appear to do anything useful, and no tests fail without it
1 parent 4616259 commit 3085d5d

File tree

5 files changed

+11
-45
lines changed

5 files changed

+11
-45
lines changed

packages/svelte/src/internal/client/dev/tracing.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,6 @@ function log_entry(signal, traces = []) {
2020
return;
2121
}
2222

23-
if (signal.trace) {
24-
var previous_captured_signals = captured_signals;
25-
var captured = new Set();
26-
set_captured_signals(captured);
27-
28-
try {
29-
untrack(signal.trace);
30-
} finally {
31-
set_captured_signals(previous_captured_signals);
32-
}
33-
34-
if (captured.size > 0) {
35-
for (const dep of captured) log_entry(dep);
36-
return;
37-
}
38-
}
39-
4023
const type = (signal.f & DERIVED) !== 0 ? '$derived' : '$state';
4124
const current_reaction = /** @type {Reaction} */ (active_reaction);
4225
const dirty = signal.wv > current_reaction.wv || current_reaction.wv === 0;

packages/svelte/src/internal/client/dom/blocks/each.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -524,16 +524,6 @@ function create_item(
524524
var v = reactive ? (mutable ? mutable_source(value) : source(value)) : value;
525525
var i = (flags & EACH_INDEX_REACTIVE) === 0 ? index : source(index);
526526

527-
if (DEV && reactive) {
528-
// For tracing purposes, we need to link the source signal we create with the
529-
// collection + index so that tracing works as intended
530-
/** @type {Value} */ (v).trace = () => {
531-
var collection_index = typeof i === 'number' ? index : i.v;
532-
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
533-
get_collection()[collection_index];
534-
};
535-
}
536-
537527
/** @type {EachItem} */
538528
var item = {
539529
i,

packages/svelte/src/internal/client/reactivity/sources.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export function source(v, stack) {
6666

6767
if (DEV && tracing_mode_flag) {
6868
signal.created = stack ?? get_stack('CreatedAt');
69-
signal.trace = null;
7069
}
7170

7271
return signal;

packages/svelte/src/internal/client/reactivity/types.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export interface Value<V = unknown> extends Signal {
2222
updated?: Error | null;
2323
trace_need_increase?: boolean;
2424
trace_v?: V;
25-
trace?: null | (() => void);
2625
}
2726

2827
export interface Reaction extends Signal {

packages/svelte/src/internal/client/runtime.js

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -779,26 +779,21 @@ export function get(signal) {
779779
active_reaction !== null &&
780780
tracing_expressions.reaction === active_reaction
781781
) {
782-
// Used when mapping state between special blocks like `each`
783-
if (signal.trace) {
784-
signal.trace();
785-
} else {
786-
var trace = get_stack('TracedAt');
782+
var trace = get_stack('TracedAt');
787783

788-
if (trace) {
789-
var traces = tracing_expressions.entries.get(signal);
784+
if (trace) {
785+
var traces = tracing_expressions.entries.get(signal);
790786

791-
if (traces === undefined) {
792-
tracing_expressions.entries.set(signal, (traces = []));
793-
}
787+
if (traces === undefined) {
788+
tracing_expressions.entries.set(signal, (traces = []));
789+
}
794790

795-
var last = traces.at(-1);
791+
var last = traces.at(-1);
796792

797-
// traces can be duplicated, e.g. by `snapshot` invoking both
798-
// both `getOwnPropertyDescriptor` and `get` traps at once
799-
if (trace.stack !== last?.stack) {
800-
traces.push(trace);
801-
}
793+
// traces can be duplicated, e.g. by `snapshot` invoking both
794+
// both `getOwnPropertyDescriptor` and `get` traps at once
795+
if (trace.stack !== last?.stack) {
796+
traces.push(trace);
802797
}
803798
}
804799
}

0 commit comments

Comments
 (0)